Merge pull request github#20440 from MathiasVP/converted-barrier-in-unbounded-write

jketema · web-flow · commit 6264f469700c · 2025-09-16T10:19:21.000+02:00
C++: Fix barrier in `cpp/unbounded-write`
diff --git a/cpp/ql/src/Security/CWE/CWE-120/UnboundedWrite.ql b/cpp/ql/src/Security/CWE/CWE-120/UnboundedWrite.ql
@@ -109,7 +109,7 @@ predicate lessThanOrEqual(IRGuardCondition g, Expr e, boolean branch) {
     g.comparesEq(left, _, _, true, branch)
   |
     interestingLessThanOrEqual(left) and
-    left.getDef().getUnconvertedResultExpression() = e
+    left.getDef().getConvertedResultExpression() = e
   )
 }
 

Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ predicate lessThanOrEqual(IRGuardCondition g, Expr e, boolean branch) {`
`109`	`109`	`g.comparesEq(left, _, _, true, branch)`
`110`	`110`	`\|`
`111`	`111`	`interestingLessThanOrEqual(left) and`
`112`		`- left.getDef().getUnconvertedResultExpression() = e`
	`112`	`+ left.getDef().getConvertedResultExpression() = e`
`113`	`113`	`)`
`114`	`114`	`}`
`115`	`115`