Merge pull request github#20059 from MathiasVP/no-more-as-expr-inUncontrolledProcessOperation

jketema · web-flow · commit 58aa7588e579 · 2025-07-15T21:17:08.000+02:00
C++: Reduce duplication in `cpp/uncontrolled-process-operation`
diff --git a/cpp/ql/src/Security/CWE/CWE-114/UncontrolledProcessOperation.ql b/cpp/ql/src/Security/CWE/CWE-114/UncontrolledProcessOperation.ql
@@ -23,7 +23,7 @@ predicate isProcessOperationExplanation(DataFlow::Node arg, string processOperat
   exists(int processOperationArg, FunctionCall call |
     isProcessOperationArgument(processOperation, processOperationArg) and
     call.getTarget().getName() = processOperation and
-    call.getArgument(processOperationArg) = [arg.asExpr(), arg.asIndirectExpr()]
+    call.getArgument(processOperationArg) = arg.asIndirectExpr()
   )
 }
 

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ predicate isProcessOperationExplanation(DataFlow::Node arg, string processOperat`
`23`	`23`	`exists(int processOperationArg, FunctionCall call \|`
`24`	`24`	`isProcessOperationArgument(processOperation, processOperationArg) and`
`25`	`25`	`call.getTarget().getName() = processOperation and`
`26`		`- call.getArgument(processOperationArg) = [arg.asExpr(), arg.asIndirectExpr()]`
	`26`	`+ call.getArgument(processOperationArg) = arg.asIndirectExpr()`
`27`	`27`	`)`
`28`	`28`	`}`
`29`	`29`