Reduce code complexity that was recently introduced

Author: constantine-nikolaou

app/controllers/jobs_controller.rb

@@ -146,20 +146,17 @@ def set_job
     end
 
     def filter_by_params(user = nil)
-      if user.nil?
-        user_jobs = Job.all
-      else
-        user_jobs = Job.user_jobs(user)
-      end
+      user_jobs = user.nil? ? Job.all : Job.user_jobs(user)
       state_params = params[:state]
 
-      if state_params == 'user'
+      case state_params
+      when 'user'
         @jobs = user_jobs
-      elsif state_params == 'draft'
+      when 'draft'
         @jobs = user_jobs.draft_jobs
-      elsif state_params == 'pending'
+      when 'pending'
         @jobs = user_jobs.pending_jobs
-      elsif state_params == 'expired'
+      when 'expired'
         @jobs = user_jobs.expired_jobs
       end
     end

app/models/job.rb

@@ -211,15 +211,14 @@ def to_text_for_social_media
     text = "#{self.company_name.titleize} is looking to hire a #{self.title}"
     text += " in #{self.location_name}" unless self.location_name.blank?
     text += ". More information here https://#{AppSettings.application_host}/jobs/#{self.to_param}"
+    
     return text
   end
 
   def to_text_for_twitter
     text = "text=#{self.company_name.titleize} is looking to hire a #{self.title}"
     text += " in #{self.location_name}" unless self.location_name.blank?
-    text += ". More information here"
-    text += "&url=https://#{AppSettings.application_host}/jobs/#{self.to_param}"
-    text += "&hashtags=#{self.location_name}"
+    text += ". More information here&url=https://#{AppSettings.application_host}/jobs/#{self.to_param}&hashtags=#{self.location_name}"
     if !self.twitter_handle.blank?
       if self.twitter_handle.start_with?('@')
         text += (" " + self.twitter_handle)