bfix,chor: fix test and requested changes

Signed-off-by: Aman <aman2@me.iitr.ac.in>

Author: aman-singh7

lib/data/services/local/storage_service.dart

@@ -51,8 +51,8 @@ class StorageService {
   /// Currently logged in user.
   static User? get user {
     try {
-      return User.fromJson(json.decode(_get<String>(AppStrings.userKey)!));
-    } on Exception catch (_) {
+      return User.fromJson(json.decode(_get<String>(AppStrings.userKey) ?? ''));
+    } on FormatException catch (_) {
       // This just means that the user has not been stored previously.
       return null;
     }

lib/presentation/core/main_app.dart

@@ -8,6 +8,7 @@ import '../../data/constants/styles.dart';
 import '../../data/services/local/image_service.dart';
 import '../../data/services/local/storage_service.dart';
 import '../../data/services/remote/api_service.dart';
+import '../../domain/repositories/user_repository.dart';
 import 'navigation_observer.dart';
 import 'router.dart';
 
@@ -47,6 +48,16 @@ class Codephile extends StatelessWidget {
     ImageService.init();
     StorageService.init();
 
+    if (StorageService.user != null) {
+      // Fetch User Details on Startup
+      try {
+        StorageService.user = await UserRepository.fetchUserDetails();
+      } on Exception catch (err) {
+        debugPrint(err.toString());
+        rethrow;
+      }
+    }
+
     return const Codephile();
   }
 }

lib/presentation/home/bloc/home_bloc.dart

@@ -3,8 +3,6 @@ import 'package:flutter/widgets.dart';
 import 'package:flutter_bloc/flutter_bloc.dart';
 import 'package:freezed_annotation/freezed_annotation.dart';
 
-import '../../../data/services/local/storage_service.dart';
-import '../../../domain/repositories/user_repository.dart';
 import '../../contests/contests_screen.dart';
 import '../../feed/feed_screen.dart';
 import '../../profile/profile_screen.dart';
@@ -20,20 +18,13 @@ class HomeBloc extends Bloc<HomeEvent, HomeState> {
   }
   late final List<Widget> screens;
 
-  void init() async {
+  void init() {
     screens = <Widget>[
       const FeedScreen(),
       const ContestsScreen(),
       const SearchScreen(),
       const ProfileScreen(),
     ];
-    // Fetch User Details on Startup
-    try {
-      StorageService.user = await UserRepository.fetchUserDetails();
-    } on Exception catch (err) {
-      debugPrint(err.toString());
-      rethrow;
-    }
   }
 
   void _changeScreen(BottomNavItemPressed event, Emitter<HomeState> emit) {

lib/presentation/profile/widgets/submission_display.dart

@@ -141,9 +141,7 @@ class SubmissionData {
   final String submissionType;
   final int value;
   final String key;
-}
 
-extension on SubmissionData {
   double percentage(int total) {
     return double.parse((value * 100 / total).toStringAsFixed(1));
   }

lib/presentation/update_profile/widgets/profile_details.dart

@@ -25,7 +25,6 @@ class ProfileDetails extends StatelessWidget {
           builder: (context, state) {
             return TextInput(
               controller: UpdateProfileBloc.controllers['name'],
-              onChanged: (val) {},
               hint: 'Name',
               errorText: state.errors['name'],
             );
@@ -36,7 +35,6 @@ class ProfileDetails extends StatelessWidget {
           builder: (context, state) {
             return TextInput(
               controller: UpdateProfileBloc.controllers['username'],
-              onChanged: (val) {},
               hint: 'Username',
               errorText: state.errors['username'],
             );