test: Add unit tests for LoginBloc.

Author: BURG3R5

.github/workflows/ci.yml

@@ -50,9 +50,8 @@ jobs:
         run: flutter pub run build_runner build --delete-conflicting-outputs
 
       # Test
-      # Temporary disabled due to absence of tests.
-      # - name: Run tests
-      #   run: flutter test
+      - name: Run tests
+        run: flutter test --no-pub test/test.dart
 
   build:
     runs-on: ubuntu-latest

.gitignore

@@ -49,3 +49,4 @@ app.*.map.json
 # Generated files
 **/*.g.dart
 **/*.freezed.dart
+coverage

.idea/runConfigurations/all_tests.xml

@@ -1,6 +1,17 @@
 class AppStrings {
+  // Storage
   static const String hiveBoxName = 'app_box';
-
   static const String authTokenKey = 'auth_token';
   static const String userKey = 'user';
+
+  // Error
+  static const String genericError = 'Something went wrong';
+  static const String incorrectCredentials = 'Incorrect credentials';
+  static const String noUserWithEmail =
+      'No user associated with given email address';
+  static const String passwordResetSuccess =
+      'Success! Please check your email for a password reset link';
+  static const String verifyFirst =
+      'Please verify your email before attempting to log in\n'
+      'Check your email for the verification link';
 }

.idea/runConfigurations/bloc_tests.xml

@@ -4,6 +4,7 @@ import 'package:freezed_annotation/freezed_annotation.dart';
 import 'package:get/get.dart';
 
 import '../../../data/constants/routes.dart';
+import '../../../data/constants/strings.dart';
 import '../../../domain/models/status.dart';
 import '../../../domain/repositories/user_repository.dart';
 
@@ -12,7 +13,7 @@ part 'login_event.dart';
 part 'login_state.dart';
 
 class LoginBloc extends Bloc<LoginEvent, LoginState> {
-  LoginBloc() : super(LoginState(rememberMe: true)) {
+  LoginBloc() : super(const LoginState()) {
     on<ToggleDialog>(_toggleDialog);
     on<PasswordInput>(_updatePasswordInput);
     on<Submit>(_submitForm);
@@ -22,6 +23,8 @@ class LoginBloc extends Bloc<LoginEvent, LoginState> {
   }
 
   void _submitForm(Submit event, Emitter<LoginState> emit) async {
+    if (!state.isFormFilled()) return;
+
     emit(state.copyWith(status: const Status.loading()));
 
     final result = await UserRepository.login(
@@ -35,50 +38,43 @@ class LoginBloc extends Bloc<LoginEvent, LoginState> {
     } else {
       if (result == 'Unverified') {
         emit(state.copyWith(
-          status: const Status.error(
-            'Please verify your email before attempting to log in\n'
-            'Check your email for the verification link',
-          ),
+          status: const Status.error(AppStrings.verifyFirst),
         ));
       } else if (result == 'Unauthorized') {
         emit(state.copyWith(
-          status: const Status.error('Incorrect credentials'),
+          status: const Status.error(AppStrings.incorrectCredentials),
         ));
       } else {
         emit(state.copyWith(
-          status: const Status.error('Something went wrong'),
+          status: const Status.error(AppStrings.genericError),
         ));
       }
     }
   }
 
   void _toggleDialog(ToggleDialog event, Emitter<LoginState> emit) async {
-    if (event.email != null) {
+    if (event.email == null) {
+      emit(state.copyWith(showDialog: !state.showDialog));
+    } else {
+      if (event.email!.isEmpty) return;
       emit(state.copyWith(
         showDialog: !state.showDialog,
         status: const Status.loading(),
       ));
-      if (event.email!.isEmpty) return;
       final result = await UserRepository.resetPassword(event.email!);
       if (result == null) {
         emit(state.copyWith(
-          status: const Status.error('Something went wrong'),
+          status: const Status.error(AppStrings.genericError),
         ));
       } else if (result) {
         emit(state.copyWith(
-          status: const Status(
-            'Success! Please check your email for a password reset link',
-          ),
+          status: const Status(AppStrings.passwordResetSuccess),
         ));
       } else {
         emit(state.copyWith(
-          status: const Status.error(
-            'No user associated with given email address',
-          ),
+          status: const Status.error(AppStrings.noUserWithEmail),
         ));
       }
-    } else {
-      emit(state.copyWith(showDialog: !state.showDialog));
     }
   }
 
@@ -91,10 +87,18 @@ class LoginBloc extends Bloc<LoginEvent, LoginState> {
   }
 
   void _updatePasswordInput(PasswordInput event, Emitter<LoginState> emit) {
-    emit(state.copyWith(password: event.value));
+    emit(state.copyWith(
+      isPasswordFocused: true,
+      isUsernameFocused: false,
+      password: event.value,
+    ));
   }
 
   void _updateUsernameInput(UsernameInput event, Emitter<LoginState> emit) {
-    emit(state.copyWith(username: event.value));
+    emit(state.copyWith(
+      isUsernameFocused: true,
+      isPasswordFocused: false,
+      username: event.value,
+    ));
   }
 }

.idea/runConfigurations/widget_tests.xml

@@ -2,8 +2,8 @@ part of 'login_bloc.dart';
 
 @freezed
 class LoginState with _$LoginState {
-  factory LoginState({
-    required bool rememberMe,
+  const factory LoginState({
+    @Default(true) bool rememberMe,
     @Default(false) bool isUsernameFocused,
     @Default(false) bool isPasswordFocused,
     @Default(true) bool obscurePassword,
@@ -15,7 +15,7 @@ class LoginState with _$LoginState {
 
   const LoginState._();
 
-  bool isFormFilled() {
-    return username.isNotEmpty && password.isNotEmpty;
-  }
+  bool isFormFilled() => username.isNotEmpty && password.isNotEmpty;
+
+  bool isLoginButtonActive() => isFormFilled() && status is! Loading;
 }

lib/data/constants/strings.dart

@@ -19,7 +19,7 @@ class LoginButton extends StatelessWidget {
           ),
           onPressed: () {
             FocusScope.of(context).requestFocus(FocusNode());
-            if (state.isFormFilled() && state.status is! Loading) {
+            if (state.isLoginButtonActive()) {
               context.read<LoginBloc>().add(const Submit());
             }
           },

lib/presentation/login/bloc/login_bloc.dart

@@ -7,14 +7,14 @@ packages:
       name: _fe_analyzer_shared
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "34.0.0"
+    version: "31.0.0"
   analyzer:
     dependency: transitive
     description:
       name: analyzer
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "3.2.0"
+    version: "2.8.0"
   args:
     dependency: transitive
     description:
@@ -36,6 +36,13 @@ packages:
       url: "https://pub.dartlang.org"
     source: hosted
     version: "8.0.2"
+  bloc_test:
+    dependency: "direct dev"
+    description:
+      name: bloc_test
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "9.0.2"
   boolean_selector:
     dependency: transitive
     description:
@@ -155,6 +162,13 @@ packages:
       url: "https://pub.dartlang.org"
     source: hosted
     version: "3.0.1"
+  coverage:
+    dependency: transitive
+    description:
+      name: coverage
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "1.0.3"
   crypto:
     dependency: transitive
     description:
@@ -169,6 +183,13 @@ packages:
       url: "https://pub.dartlang.org"
     source: hosted
     version: "2.2.1"
+  diff_match_patch:
+    dependency: transitive
+    description:
+      name: diff_match_patch
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "0.4.1"
   dio:
     dependency: "direct main"
     description:
@@ -344,7 +365,7 @@ packages:
       name: freezed
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "1.1.1"
+    version: "1.1.0"
   freezed_annotation:
     dependency: "direct main"
     description:
@@ -492,13 +513,27 @@ packages:
       url: "https://pub.dartlang.org"
     source: hosted
     version: "1.0.1"
+  mocktail:
+    dependency: "direct dev"
+    description:
+      name: mocktail
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "0.2.0"
   nested:
     dependency: transitive
     description:
       name: nested
       url: "https://pub.dartlang.org"
     source: hosted
     version: "1.0.0"
+  node_preamble:
+    dependency: transitive
+    description:
+      name: node_preamble
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "2.0.1"
   package_config:
     dependency: transitive
     description:
@@ -695,6 +730,20 @@ packages:
       url: "https://pub.dartlang.org"
     source: hosted
     version: "1.2.0"
+  shelf_packages_handler:
+    dependency: transitive
+    description:
+      name: shelf_packages_handler
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "3.0.0"
+  shelf_static:
+    dependency: transitive
+    description:
+      name: shelf_static
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "1.1.0"
   shelf_web_socket:
     dependency: transitive
     description:
@@ -721,6 +770,20 @@ packages:
       url: "https://pub.dartlang.org"
     source: hosted
     version: "1.3.1"
+  source_map_stack_trace:
+    dependency: transitive
+    description:
+      name: source_map_stack_trace
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "2.1.0"
+  source_maps:
+    dependency: transitive
+    description:
+      name: source_maps
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "0.10.10"
   source_span:
     dependency: transitive
     description:
@@ -770,13 +833,27 @@ packages:
       url: "https://pub.dartlang.org"
     source: hosted
     version: "1.2.0"
+  test:
+    dependency: transitive
+    description:
+      name: test
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "1.19.5"
   test_api:
     dependency: transitive
     description:
       name: test_api
       url: "https://pub.dartlang.org"
     source: hosted
     version: "0.4.8"
+  test_core:
+    dependency: transitive
+    description:
+      name: test_core
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "0.4.9"
   timing:
     dependency: transitive
     description:
@@ -805,6 +882,13 @@ packages:
       url: "https://pub.dartlang.org"
     source: hosted
     version: "2.1.1"
+  vm_service:
+    dependency: transitive
+    description:
+      name: vm_service
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "7.5.0"
   watcher:
     dependency: transitive
     description:
@@ -819,6 +903,13 @@ packages:
       url: "https://pub.dartlang.org"
     source: hosted
     version: "2.1.0"
+  webkit_inspection_protocol:
+    dependency: transitive
+    description:
+      name: webkit_inspection_protocol
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "1.0.0"
   win32:
     dependency: transitive
     description: