|
| 1 | +From b4865b976ef02fe69bb0d03c6fda6ecb2f173bcb Mon Sep 17 00:00:00 2001 |
| 2 | +From: Aun-Ali Zaidi <admin@kodeit.net> |
| 3 | +Date: Fri, 10 Jan 2020 19:41:21 -0600 |
| 4 | +Subject: [PATCH 2/2] brcmfmac: Add ability to manually specify FW rambase |
| 5 | + address |
| 6 | + |
| 7 | +This commit introduces the ability to manually pass the rambase address for |
| 8 | +the brcmfmac chip as a kernel module option. The existing brcmf_chip_tcm_rambase() |
| 9 | +function is bypassed when this option is supplied. This is very useful when |
| 10 | +debugging support for newer chipsets that are not provided by the aforementioned |
| 11 | +function. |
| 12 | + |
| 13 | +Tested-by: Aun-Ali Zaidi <admin@kodeit.net> |
| 14 | +Signed-off-by: Aun-Ali Zaidi <admin@kodeit.net> |
| 15 | +--- |
| 16 | + .../wireless/broadcom/brcm80211/brcmfmac/chip.c | 17 ++++++++++------- |
| 17 | + .../wireless/broadcom/brcm80211/brcmfmac/chip.h | 7 +++++-- |
| 18 | + .../broadcom/brcm80211/brcmfmac/common.c | 5 +++++ |
| 19 | + .../broadcom/brcm80211/brcmfmac/common.h | 1 - |
| 20 | + .../wireless/broadcom/brcm80211/brcmfmac/pcie.c | 4 ++-- |
| 21 | + .../wireless/broadcom/brcm80211/brcmfmac/sdio.c | 2 +- |
| 22 | + .../broadcom/brcm80211/brcmfmac/settings.h | 4 ++++ |
| 23 | + 7 files changed, 27 insertions(+), 13 deletions(-) |
| 24 | + |
| 25 | +diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c |
| 26 | +index a795d781b4c5..e6b6f23e15a5 100644 |
| 27 | +--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c |
| 28 | ++++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c |
| 29 | +@@ -696,7 +696,7 @@ static u32 brcmf_chip_tcm_rambase(struct brcmf_chip_priv *ci) |
| 30 | + return 0; |
| 31 | + } |
| 32 | + |
| 33 | +-int brcmf_chip_get_raminfo(struct brcmf_chip *pub) |
| 34 | ++int brcmf_chip_get_raminfo(struct brcmf_chip *pub, struct brcmf_mp_device *settings) |
| 35 | + { |
| 36 | + struct brcmf_chip_priv *ci = container_of(pub, struct brcmf_chip_priv, |
| 37 | + pub); |
| 38 | +@@ -707,7 +707,8 @@ int brcmf_chip_get_raminfo(struct brcmf_chip *pub) |
| 39 | + if (mem) { |
| 40 | + mem_core = container_of(mem, struct brcmf_core_priv, pub); |
| 41 | + ci->pub.ramsize = brcmf_chip_tcm_ramsize(mem_core); |
| 42 | +- ci->pub.rambase = brcmf_chip_tcm_rambase(ci); |
| 43 | ++ ci->pub.rambase = (settings != NULL && settings->rambase_addr > 0) ? settings->rambase_addr |
| 44 | ++ : brcmf_chip_tcm_rambase(ci); |
| 45 | + if (!ci->pub.rambase) { |
| 46 | + brcmf_err("RAM base not provided with ARM CR4 core\n"); |
| 47 | + return -EINVAL; |
| 48 | +@@ -718,7 +719,8 @@ int brcmf_chip_get_raminfo(struct brcmf_chip *pub) |
| 49 | + mem_core = container_of(mem, struct brcmf_core_priv, |
| 50 | + pub); |
| 51 | + ci->pub.ramsize = brcmf_chip_sysmem_ramsize(mem_core); |
| 52 | +- ci->pub.rambase = brcmf_chip_tcm_rambase(ci); |
| 53 | ++ ci->pub.rambase = (settings != NULL && settings->rambase_addr > 0) ? settings->rambase_addr |
| 54 | ++ : brcmf_chip_tcm_rambase(ci); |
| 55 | + if (!ci->pub.rambase) { |
| 56 | + brcmf_err("RAM base not provided with ARM CA7 core\n"); |
| 57 | + return -EINVAL; |
| 58 | +@@ -904,7 +906,7 @@ int brcmf_chip_dmp_erom_scan(struct brcmf_chip_priv *ci) |
| 59 | + return 0; |
| 60 | + } |
| 61 | + |
| 62 | +-static int brcmf_chip_recognition(struct brcmf_chip_priv *ci) |
| 63 | ++static int brcmf_chip_recognition(struct brcmf_chip_priv *ci, struct brcmf_mp_device *settings) |
| 64 | + { |
| 65 | + struct brcmf_core *core; |
| 66 | + u32 regdata; |
| 67 | +@@ -977,7 +979,7 @@ static int brcmf_chip_recognition(struct brcmf_chip_priv *ci) |
| 68 | + brcmf_chip_set_passive(&ci->pub); |
| 69 | + } |
| 70 | + |
| 71 | +- return brcmf_chip_get_raminfo(&ci->pub); |
| 72 | ++ return brcmf_chip_get_raminfo(&ci->pub, settings); |
| 73 | + } |
| 74 | + |
| 75 | + static void brcmf_chip_disable_arm(struct brcmf_chip_priv *chip, u16 id) |
| 76 | +@@ -1051,7 +1053,8 @@ static int brcmf_chip_setup(struct brcmf_chip_priv *chip) |
| 77 | + } |
| 78 | + |
| 79 | + struct brcmf_chip *brcmf_chip_attach(void *ctx, |
| 80 | +- const struct brcmf_buscore_ops *ops) |
| 81 | ++ const struct brcmf_buscore_ops *ops, |
| 82 | ++ struct brcmf_mp_device *settings) |
| 83 | + { |
| 84 | + struct brcmf_chip_priv *chip; |
| 85 | + int err = 0; |
| 86 | +@@ -1080,7 +1083,7 @@ struct brcmf_chip *brcmf_chip_attach(void *ctx, |
| 87 | + if (err < 0) |
| 88 | + goto fail; |
| 89 | + |
| 90 | +- err = brcmf_chip_recognition(chip); |
| 91 | ++ err = brcmf_chip_recognition(chip, settings); |
| 92 | + if (err < 0) |
| 93 | + goto fail; |
| 94 | + |
| 95 | +diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.h b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.h |
| 96 | +index 7b00f6a59e89..db982154e0d3 100644 |
| 97 | +--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.h |
| 98 | ++++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.h |
| 99 | +@@ -7,6 +7,8 @@ |
| 100 | + |
| 101 | + #include <linux/types.h> |
| 102 | + |
| 103 | ++#include "settings.h" |
| 104 | ++ |
| 105 | + #define CORE_CC_REG(base, field) \ |
| 106 | + (base + offsetof(struct chipcregs, field)) |
| 107 | + |
| 108 | +@@ -69,9 +71,10 @@ struct brcmf_buscore_ops { |
| 109 | + void (*activate)(void *ctx, struct brcmf_chip *chip, u32 rstvec); |
| 110 | + }; |
| 111 | + |
| 112 | +-int brcmf_chip_get_raminfo(struct brcmf_chip *pub); |
| 113 | ++int brcmf_chip_get_raminfo(struct brcmf_chip *pub, struct brcmf_mp_device *settings); |
| 114 | + struct brcmf_chip *brcmf_chip_attach(void *ctx, |
| 115 | +- const struct brcmf_buscore_ops *ops); |
| 116 | ++ const struct brcmf_buscore_ops *ops, |
| 117 | ++ struct brcmf_mp_device *settings); |
| 118 | + void brcmf_chip_detach(struct brcmf_chip *chip); |
| 119 | + struct brcmf_core *brcmf_chip_get_core(struct brcmf_chip *chip, u16 coreid); |
| 120 | + struct brcmf_core *brcmf_chip_get_d11core(struct brcmf_chip *pub, u8 unit); |
| 121 | +diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c |
| 122 | +index dec25e415619..384549237cce 100644 |
| 123 | +--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c |
| 124 | ++++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c |
| 125 | +@@ -67,6 +67,10 @@ static int brcmf_iapp_enable; |
| 126 | + module_param_named(iapp, brcmf_iapp_enable, int, 0); |
| 127 | + MODULE_PARM_DESC(iapp, "Enable partial support for the obsoleted Inter-Access Point Protocol"); |
| 128 | + |
| 129 | ++static uint brcmf_rambase_addr; |
| 130 | ++module_param_named(rambase_addr, brcmf_rambase_addr, uint, 0); |
| 131 | ++MODULE_PARM_DESC(rambase_addr, "Manually specify FW shared rambase address"); |
| 132 | ++ |
| 133 | + #ifdef DEBUG |
| 134 | + /* always succeed brcmf_bus_started() */ |
| 135 | + static int brcmf_ignore_probe_fail; |
| 136 | +@@ -416,6 +420,7 @@ struct brcmf_mp_device *brcmf_get_module_param(struct device *dev, |
| 137 | + #ifdef DEBUG |
| 138 | + settings->ignore_probe_fail = !!brcmf_ignore_probe_fail; |
| 139 | + #endif |
| 140 | ++ settings->rambase_addr = brcmf_rambase_addr; |
| 141 | + |
| 142 | + if (bus_type == BRCMF_BUSTYPE_SDIO) |
| 143 | + settings->bus.sdio.txglomsz = brcmf_sdiod_txglomsz; |
| 144 | +diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.h b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.h |
| 145 | +index 3826403ec5ff..c7a93e04a5f5 100644 |
| 146 | +--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.h |
| 147 | ++++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.h |
| 148 | +@@ -6,7 +6,6 @@ |
| 149 | + #define BRCMFMAC_COMMON_H |
| 150 | + |
| 151 | + #include <linux/platform_device.h> |
| 152 | +-#include <linux/platform_data/brcmfmac.h> |
| 153 | + #include "fwil_types.h" |
| 154 | + #include "settings.h" |
| 155 | + |
| 156 | +diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c |
| 157 | +index f64ce5074a55..ba42e1404683 100644 |
| 158 | +--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c |
| 159 | ++++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c |
| 160 | +@@ -1770,7 +1770,7 @@ static void brcmf_pcie_setup(struct device *dev, int ret, |
| 161 | + nvram_len = fwreq->items[BRCMF_PCIE_FW_NVRAM].nv_data.len; |
| 162 | + kfree(fwreq); |
| 163 | + |
| 164 | +- ret = brcmf_chip_get_raminfo(devinfo->ci); |
| 165 | ++ ret = brcmf_chip_get_raminfo(devinfo->ci, devinfo->settings); |
| 166 | + if (ret) { |
| 167 | + brcmf_err(bus, "Failed to get RAM info\n"); |
| 168 | + goto fail; |
| 169 | +@@ -1882,7 +1882,7 @@ brcmf_pcie_probe(struct pci_dev *pdev, const struct pci_device_id *id) |
| 170 | + |
| 171 | + devinfo->pdev = pdev; |
| 172 | + pcie_bus_dev = NULL; |
| 173 | +- devinfo->ci = brcmf_chip_attach(devinfo, &brcmf_pcie_buscore_ops); |
| 174 | ++ devinfo->ci = brcmf_chip_attach(devinfo, &brcmf_pcie_buscore_ops, devinfo->settings); |
| 175 | + if (IS_ERR(devinfo->ci)) { |
| 176 | + ret = PTR_ERR(devinfo->ci); |
| 177 | + devinfo->ci = NULL; |
| 178 | +diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c |
| 179 | +index 264ad63232f8..2f0dc4002e88 100644 |
| 180 | +--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c |
| 181 | ++++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c |
| 182 | +@@ -3921,7 +3921,7 @@ brcmf_sdio_probe_attach(struct brcmf_sdio *bus) |
| 183 | + goto fail; |
| 184 | + } |
| 185 | + |
| 186 | +- bus->ci = brcmf_chip_attach(sdiodev, &brcmf_sdio_buscore_ops); |
| 187 | ++ bus->ci = brcmf_chip_attach(sdiodev, &brcmf_sdio_buscore_ops, sdiodev->settings); |
| 188 | + if (IS_ERR(bus->ci)) { |
| 189 | + brcmf_err("brcmf_chip_attach failed!\n"); |
| 190 | + bus->ci = NULL; |
| 191 | +diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/settings.h b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/settings.h |
| 192 | +index 5c4aa32fb73d..9840a4cd3b2e 100644 |
| 193 | +--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/settings.h |
| 194 | ++++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/settings.h |
| 195 | +@@ -6,6 +6,8 @@ |
| 196 | + #ifndef BRCMFMAC_SETTINGS_H |
| 197 | + #define BRCMFMAC_SETTINGS_H |
| 198 | + |
| 199 | ++#include <linux/platform_data/brcmfmac.h> |
| 200 | ++ |
| 201 | + /* Definition for the device specific settings are defined here. One struct |
| 202 | + * is used called brcmf_mp_device. The device specific settings is part of |
| 203 | + * the drvr struct and should be initialized on every brcmf_attach. |
| 204 | +@@ -21,6 +23,7 @@ |
| 205 | + * @ignore_probe_fail: Ignore probe failure. |
| 206 | + * @country_codes: If available, pointer to struct for translating country codes |
| 207 | + * @bus: Bus specific platform data. Only SDIO at the mmoment. |
| 208 | ++ * @rambase_addr: Manually specified FW shared rambase address. |
| 209 | + */ |
| 210 | + struct brcmf_mp_device { |
| 211 | + bool p2p_enable; |
| 212 | +@@ -34,6 +37,7 @@ struct brcmf_mp_device { |
| 213 | + union { |
| 214 | + struct brcmfmac_sdio_pd sdio; |
| 215 | + } bus; |
| 216 | ++ u32 rambase_addr; |
| 217 | + }; |
| 218 | + |
| 219 | + #endif /* BRCMFMAC_SETTINGS_H */ |
| 220 | +-- |
| 221 | +2.24.1 |
0 commit comments