Simplify app and logger options

Author: razor-x

examples/index.js

@@ -12,8 +12,8 @@ const commands = [health]
 
 const createAppContext = async (argv) => {
   const config = await getConfig(env)
-  const logger = createLogger({ config })
-  const app = createApp({ config, logger })
+  const logger = createLogger(config)
+  const app = createApp(logger, config)
   if (argv.start) await app.start()
   argv.app = app
 }

lib/app.js

@@ -2,14 +2,14 @@ import { createServer } from 'node:http'
 
 import { Daemon } from './daemon.js'
 
-export const createApp = ({ config, logger }) => new App({ config, logger })
+export const createApp = (logger, config) => new App(logger, config)
 
 class App {
   #daemon
   #config
   #logger
 
-  constructor({ config, logger }) {
+  constructor(logger, config) {
     this.#config = config
     this.#logger = logger
   }

lib/logger.js

@@ -3,10 +3,13 @@ import { Writable } from 'node:stream'
 import { pino } from 'pino'
 import pinoPretty from 'pino-pretty'
 
-export const createLogger = ({ t, config } = {}) => {
-  const options = {}
-  if (config?.logLevel != null) options.level = config.logLevel
-  if (config?.useProductionLogger) return pino(options)
+export const createLogger = ({
+  t,
+  logLevel = 'info',
+  useProductionLogger = false
+} = {}) => {
+  const options = { level: logLevel }
+  if (useProductionLogger) return pino(options)
   if (t != null) return createTestLogger(t, options)
   return pino(options, pinoPretty.default())
 }

server.js

@@ -28,8 +28,8 @@ const args = await yargs(argv.slice(2))
 try {
   const { NODE_ENV } = args
   const config = await getConfig({ ...env, NODE_ENV })
-  const logger = createLogger({ config })
-  const app = createApp({ config, logger })
+  const logger = createLogger(config)
+  const app = createApp(logger, config)
   await app.start()
   logger.info(`Server: ${app.baseUrl}`)
 } catch (err) {

test/fixtures/app.js

@@ -20,7 +20,7 @@ export const getTestApp = async (t) => {
     NODE_ENV: 'test',
     PORT: argv.includes('--smoke') ? env.PORT : port.toString()
   })
-  const logger = createLogger({ config, t })
-  const app = createApp({ config, logger })
+  const logger = createLogger({ ...config, t })
+  const app = createApp(logger, config)
   return app
 }