diff --git a/packages/@magic-sdk/provider/src/modules/third-party-wallets.ts b/packages/@magic-sdk/provider/src/modules/third-party-wallets.ts index 2c68db825..225d72d00 100644 --- a/packages/@magic-sdk/provider/src/modules/third-party-wallets.ts +++ b/packages/@magic-sdk/provider/src/modules/third-party-wallets.ts @@ -104,7 +104,7 @@ export class ThirdPartyWalletsModule extends BaseModule { } private magicWidgetLogout(payload: Partial): PromiEvent { - return createPromiEvent(async resolve => { + return createPromiEvent((resolve, reject) => { try { // @ts-expect-error Property 'walletKit' does not exist on type 'SDKBase'. this.sdk.walletKit.clearConnectedState(); @@ -112,7 +112,7 @@ export class ThirdPartyWalletsModule extends BaseModule { console.error(error); } - return super.requestOverlay(payload); + super.requestOverlay(payload).then(resolve).catch(reject); }); } diff --git a/packages/@magic-sdk/provider/test/spec/modules/third-party-wallet/magicWidgetLogout.spec.ts b/packages/@magic-sdk/provider/test/spec/modules/third-party-wallet/magicWidgetLogout.spec.ts new file mode 100644 index 000000000..562e25ad7 --- /dev/null +++ b/packages/@magic-sdk/provider/test/spec/modules/third-party-wallet/magicWidgetLogout.spec.ts @@ -0,0 +1,48 @@ +import { createMagicSDK } from '../../../factories'; +import { mockLocalStorage } from '../../../mocks'; +import { BaseModule } from '../../../../src/modules/base-module'; + +beforeEach(() => { + jest.restoreAllMocks(); + mockLocalStorage(); +}); + +describe('third party wallet magicWidgetLogout', () => { + it('should resolve with the result of the overlay logout request', async () => { + const payload = { method: 'magic_auth_logout' }; + const magic = createMagicSDK(); + const clearConnectedState = jest.fn(); + (magic as any).walletKit = { clearConnectedState }; + // @ts-expect-error 'requestOverlay' is protected + jest.spyOn(BaseModule.prototype, 'requestOverlay').mockImplementation(() => Promise.resolve(true)); + + const result = await magic.thirdPartyWallets.magicWidgetLogout(payload); + + expect(clearConnectedState).toHaveBeenCalled(); + expect(result).toBe(true); + }); + + it('should reject if the overlay logout request fails', async () => { + const payload = { method: 'magic_auth_logout' }; + const magic = createMagicSDK(); + (magic as any).walletKit = { clearConnectedState: jest.fn() }; + const error = new Error('logout failed'); + // @ts-expect-error 'requestOverlay' is protected + jest.spyOn(BaseModule.prototype, 'requestOverlay').mockImplementation(() => Promise.reject(error)); + + await expect(magic.thirdPartyWallets.magicWidgetLogout(payload)).rejects.toBe(error); + }); + + it('should still request the overlay logout if clearing wallet kit state throws', async () => { + const payload = { method: 'magic_auth_logout' }; + const magic = createMagicSDK(); + jest.spyOn(console, 'error').mockImplementation(() => {}); + // @ts-expect-error 'requestOverlay' is protected + jest.spyOn(BaseModule.prototype, 'requestOverlay').mockImplementation(() => Promise.resolve(true)); + + const result = await magic.thirdPartyWallets.magicWidgetLogout(payload); + + expect(console.error).toHaveBeenCalled(); + expect(result).toBe(true); + }); +});