MDEE-342: adapt feed limit reeindex to be in seconds.

Author: obarcelonap

DataExporter/Model/Indexer/AllIdsResolver.php

@@ -85,12 +85,12 @@ private function getIdsSelect(int $lastKnownId, FeedIndexMetadata $metadata, Dat
             )
             ->where($whereClause, $lastKnownId);
 
-        if ($metadata->getFullReIndexDaysLimit() != 0) {
+        if ($metadata->getFullReIndexSecondsLimit() != 0) {
             $select->where(sprintf(
-                "s.%s >= DATE_SUB(STR_TO_DATE('%s', '%%Y-%%m-%%d %%H:%%i:%%s'), INTERVAL %d DAY)",
-                $metadata->getSourceTableFieldOnFullReIndexDaysLimit(),
+                "s.%s >= DATE_SUB(STR_TO_DATE('%s', '%%Y-%%m-%%d %%H:%%i:%%s'), INTERVAL %d SECOND)",
+                $metadata->getSourceTableFieldOnFullReIndexLimit(),
                 $dateTime->format('Y-m-d H:i:s'),
-                $metadata->getFullReIndexDaysLimit()
+                $metadata->getFullReIndexSecondsLimit()
             ));
         }
 

DataExporter/Model/Indexer/FeedIndexMetadata.php

@@ -62,12 +62,12 @@ class FeedIndexMetadata
     /**
      * @var int
      */
-    private $fullReindexDaysLimit;
+    private $fullReindexSecondsLimit;
 
     /**
      * @var string
      */
-    private $sourceTableFieldOnFullReIndexDaysLimit;
+    private $sourceTableFieldOnFullReIndexLimit;
 
     /**
      * @param string $feedName
@@ -79,6 +79,8 @@ class FeedIndexMetadata
      * @param array $feedTableMutableColumns
      * @param int $batchSize
      * @param string|null $sourceTableIdentityField
+     * @param int $fullReIndexSecondsLimit
+     * @param string $sourceTableFieldOnFullReIndexLimit
      */
     public function __construct(
         string $feedName,
@@ -90,8 +92,8 @@ public function __construct(
         array $feedTableMutableColumns,
         int $batchSize = 100,
         string $sourceTableIdentityField = null,
-        int $fullReIndexDaysLimit = 0,
-        string $sourceTableFieldOnFullReIndexDaysLimit = 'updated_at'
+        int $fullReIndexSecondsLimit = 0,
+        string $sourceTableFieldOnFullReIndexLimit = 'updated_at'
     ) {
         $this->feedName = $feedName;
         $this->sourceTableName = $sourceTableName;
@@ -102,8 +104,8 @@ public function __construct(
         $this->feedTableMutableColumns = $feedTableMutableColumns;
         $this->batchSize = $batchSize;
         $this->sourceTableIdentityField = $sourceTableIdentityField ?? $sourceTableField;
-        $this->fullReindexDaysLimit = $fullReIndexDaysLimit;
-        $this->sourceTableFieldOnFullReIndexDaysLimit = $sourceTableFieldOnFullReIndexDaysLimit;
+        $this->fullReindexSecondsLimit = $fullReIndexSecondsLimit;
+        $this->sourceTableFieldOnFullReIndexLimit = $sourceTableFieldOnFullReIndexLimit;
     }
 
     /**
@@ -197,20 +199,20 @@ public function getFeedTableMutableColumns(): array
     }
 
     /**
-     * Determines the amount of days back when triggering a full reindex
-     * @return int the amount in days, 0 means no limit
+     * Determines the amount of seconds back in time when triggering a full reindex
+     * @return int the amount in seconds, 0 means no limit
      */
-    public function getFullReIndexDaysLimit(): int
+    public function getFullReIndexSecondsLimit(): int
     {
-        return $this->fullReindexDaysLimit;
+        return $this->fullReindexSecondsLimit;
     }
 
     /**
-     * Table field name to use when full reindex is limited by days back (see fullReindexDaysLimit)
+     * Table field name to use when full reindex is limited (see fullReindexSecondsLimit)
      * @return string the field name
      */
-    public function getSourceTableFieldOnFullReIndexDaysLimit(): string
+    public function getSourceTableFieldOnFullReIndexLimit(): string
     {
-        return $this->sourceTableFieldOnFullReIndexDaysLimit;
+        return $this->sourceTableFieldOnFullReIndexLimit;
     }
 }

SalesOrdersDataExporter/README.md

@@ -30,7 +30,8 @@ Current time will be used by default
 ```
 
 ### Reindexing
-To export full orders data simply run reindex command:
+To export orders data simply run reindex command:
 ```shell
 bin/magento indexer:reindex sales_order_data_exporter_v2
 ```
+Note currently reindexing is limited to orders modified in the last 7 days.

SalesOrdersDataExporter/etc/di.xml

@@ -19,8 +19,8 @@
             <argument name="feedTableMutableColumns" xsi:type="array">
                 <item name="feed_data" xsi:type="string">feed_data</item>
             </argument>
-            <argument name="fullReIndexDaysLimit" xsi:type="number">7</argument>
-            <argument name="sourceTableFieldOnFullReIndexDaysLimit" xsi:type="string">updated_at</argument>
+            <argument name="fullReIndexSecondsLimit" xsi:type="number">604800</argument> <!-- 7 days -->
+            <argument name="sourceTableFieldOnFullReIndexLimit" xsi:type="string">updated_at</argument>
         </arguments>
     </virtualType>
     <virtualType name="Magento\SalesOrdersDataExporter\Model\Indexer\OrdersFeedIndexer" type="Magento\DataExporter\Model\Indexer\FeedIndexer">