European Portuguese (pt-PT) translation: is it welcome, and what scope?

[mclaudiopt]

Hi, and thanks for Visor.

I would like to contribute a European Portuguese (pt-PT) translation. I am a native speaker. Before I start, a few questions so the work fits the project:

1. Is a new language welcome? CONTRIBUTING.md asks for English and Italian on new strings; I saw values-it and values-ru but no Portuguese.
2. Which folder do you prefer, values-pt-rPT/ or a neutral values-pt/? I would default to values-pt-rPT/.
3. Scope, as I understand it from the code. Please say what you want and what you would leave out:
   • app/src/main/res/values/strings.xml (859 strings, 13 plurals) as values-pt-rPT/strings.xml.
   • settings_ui.json: add label_pt, note_pt and detail_pt where the catalogue has them (I see label_it on only a small part of the labels, so I would start with the user-facing ones).
   • FALLBACKS in Assistant.kt: the pt entry reads as Brazilian Portuguese ("conectado", "app"). I could suggest a pt-PT wording, or add a separate key if you prefer.
   • GlassesLanguages.kt: voice tone labels only exist in English and Italian, so a new language would need a small code change. I would leave that to you unless you want a PR.
4. I cannot build with the Meta tokens, so I will not be able to try the strings on real glasses. Is a pull request with only resource files, reviewed by reading them, acceptable? I would say so in the PR.

If this is fine, I will open a PR with values-pt-rPT/strings.xml first and follow up with the rest.

Thanks!

[macedonga]

Thanks for offering, and for asking first. Yes, European Portuguese is welcome. To your questions:

1. Yes. The English and Italian rule is for people who add new text, not for new languages.
2. values-pt-rPT/, as you suggest.
3. Start with strings.xml. The _pt labels in settings_ui.json are welcome after that, and I'll add the code that reads them. Leave FALLBACKS and GlassesLanguages.kt to me.
4. A PR with only resource files is fine, just say so in it. You can also build the app: the Meta tokens are optional at build time, and only setup and login need them. CI builds every PR that way.