Skip to content

Commit 27d20d9

Browse files
authored
[HIP] Leave test-suite flags untouched (#350)
Create a local set of flags instead of changing the global list of flags. The previous version leads to errors when enabling the catch2 tests. After some internal discussion, I think it makes probably sense to enable verbose mode for running HIP tests by default.
1 parent cbda52f commit 27d20d9

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

External/HIP/CMakeLists.txt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -146,13 +146,14 @@ function(create_hip_test VariantSuffix)
146146
create_local_hip_tests(${VariantSuffix})
147147
add_dependencies(hip-tests-simple hip-tests-simple-${VariantSuffix})
148148

149+
# Enable verbose output for running HIP tests.
150+
set(HIP_LIT_FLAGS "-v")
149151
if (HIP_EXPORT_XUNIT_XML)
150-
set(HIP_LIT_FLAGS --xunit-xml-output hip-results-${VariantSuffix}.xml)
151-
list(APPEND TEST_SUITE_LIT_FLAGS "${HIP_LIT_FLAGS}")
152+
list(APPEND HIP_LIT_FLAGS --xunit-xml-output hip-results-${VariantSuffix}.xml)
152153
endif()
153154

154155
add_custom_target(check-hip-simple-${VariantSuffix}
155-
COMMAND ${TEST_SUITE_LIT} ${TEST_SUITE_LIT_FLAGS}
156+
COMMAND ${TEST_SUITE_LIT} ${HIP_LIT_FLAGS}
156157
${VARIANT_SIMPLE_TEST_TARGETS}
157158
WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
158159
DEPENDS hip-tests-simple-${VariantSuffix}

0 commit comments

Comments
 (0)