[SoundCloud] Purged Top 50

They no longer exists and the API returns nothing for them.

Overall SoundCloud seems to use a new system.

Author: litetex

extractor/src/main/java/org/schabi/newpipe/extractor/services/soundcloud/extractors/SoundcloudChartsExtractor.java

@@ -40,14 +40,10 @@ public void onFetchPage(@Nonnull final Downloader downloader)
 
         initialFetchCollector = new StreamInfoItemsCollector(getServiceId());
 
-        String apiUrl = SOUNDCLOUD_API_V2_URL + "charts" + "?genre=soundcloud:genres:all-music"
-            + "&client_id=" + SoundcloudParsingHelper.clientId();
-
-        if (getId().equals("Top 50")) {
-            apiUrl += "&kind=top";
-        } else {
-            apiUrl += "&kind=trending";
-        }
+        final String apiUrl = SOUNDCLOUD_API_V2_URL + "charts"
+            + "?genre=soundcloud:genres:all-music"
+            + "&client_id=" + SoundcloudParsingHelper.clientId()
+            + "&kind=trending";
 
         final ContentCountry contentCountry = SoundCloud.getContentCountry();
         String apiUrlWithRegion = null;

extractor/src/main/java/org/schabi/newpipe/extractor/services/soundcloud/linkHandler/SoundcloudChartsLinkHandlerFactory.java

@@ -11,8 +11,6 @@ public final class SoundcloudChartsLinkHandlerFactory extends ListLinkHandlerFac
     private static final SoundcloudChartsLinkHandlerFactory INSTANCE =
             new SoundcloudChartsLinkHandlerFactory();
 
-    private static final String TOP_URL_PATTERN =
-            "^https?://(www\\.|m\\.)?soundcloud.com/charts(/top)?/?([#?].*)?$";
     private static final String URL_PATTERN =
             "^https?://(www\\.|m\\.)?soundcloud.com/charts(/top|/new)?/?([#?].*)?$";
 
@@ -25,23 +23,15 @@ public static SoundcloudChartsLinkHandlerFactory getInstance() {
 
     @Override
     public String getId(final String url) throws ParsingException, UnsupportedOperationException {
-        if (Parser.isMatch(TOP_URL_PATTERN, url.toLowerCase())) {
-            return "Top 50";
-        } else {
-            return "New & hot";
-        }
+        return "New & hot";
     }
 
     @Override
     public String getUrl(final String id,
                          final List<String> contentFilter,
                          final String sortFilter)
             throws ParsingException, UnsupportedOperationException {
-        if (id.equals("Top 50")) {
-            return "https://soundcloud.com/charts/top";
-        } else {
-            return "https://soundcloud.com/charts/new";
-        }
+        return "https://soundcloud.com/charts/new";
     }
 
     @Override

extractor/src/test/java/org/schabi/newpipe/extractor/services/soundcloud/SoundcloudChartsLinkHandlerFactoryTest.java

@@ -24,13 +24,11 @@ public static void setUp() {
 
     @Test
     public void getUrl() throws Exception {
-        assertEquals("https://soundcloud.com/charts/top", linkHandler.fromId("Top 50").getUrl());
         assertEquals("https://soundcloud.com/charts/new", linkHandler.fromId("New & hot").getUrl());
     }
 
     @Test
     public void getId() throws ParsingException {
-        assertEquals("Top 50", linkHandler.fromUrl("http://soundcloud.com/charts/top?genre=all-music").getId());
         assertEquals("New & hot", linkHandler.fromUrl("HTTP://www.soundcloud.com/charts/new/?genre=all-music&country=all-countries").getId());
     }