Skip to content

Commit 4cd12c9

Browse files
committed
YoutubeServiceTest requires the Downloader but never uses it
1 parent e723b03 commit 4cd12c9

1 file changed

Lines changed: 20 additions & 6 deletions

File tree

extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeServiceTest.java

Lines changed: 20 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,15 @@
2525
import static org.junit.jupiter.api.Assertions.assertInstanceOf;
2626
import static org.schabi.newpipe.extractor.ServiceList.YouTube;
2727

28+
import org.jetbrains.annotations.NotNull;
2829
import org.junit.jupiter.api.BeforeAll;
2930
import org.junit.jupiter.api.Test;
31+
import org.schabi.newpipe.extractor.InitNewPipeTest;
32+
import org.schabi.newpipe.extractor.NewPipe;
3033
import org.schabi.newpipe.extractor.StreamingService;
34+
import org.schabi.newpipe.extractor.downloader.Downloader;
35+
import org.schabi.newpipe.extractor.downloader.Request;
36+
import org.schabi.newpipe.extractor.downloader.Response;
3137
import org.schabi.newpipe.extractor.kiosk.KioskList;
3238
import org.schabi.newpipe.extractor.playlist.PlaylistExtractor;
3339
import org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeMixPlaylistExtractor;
@@ -36,14 +42,22 @@
3642
/**
3743
* Test for {@link YoutubeService}
3844
*/
39-
public class YoutubeServiceTest implements InitYoutubeTest {
40-
StreamingService service;
41-
KioskList kioskList;
45+
public class YoutubeServiceTest {
46+
static StreamingService service;
47+
static KioskList kioskList;
4248

43-
@Override
4449
@BeforeAll
45-
public void setUp() throws Exception {
46-
InitYoutubeTest.super.setUp();
50+
public static void setUp() throws Exception {
51+
InitNewPipeTest.initEmpty();
52+
// Init with dummy as
53+
// * a downloader is required otherwise a NPE is thrown during extract initialization
54+
// * nothing will be transmitted
55+
NewPipe.init(new Downloader() {
56+
@Override
57+
public Response execute(@NotNull final Request request) {
58+
throw new UnsupportedOperationException("No communication expected");
59+
}
60+
});
4761
service = YouTube;
4862
kioskList = service.getKioskList();
4963
}

0 commit comments

Comments
 (0)