Skip to content

Commit d21fac6

Browse files
committed
Remove playlist details toasts
1 parent c537776 commit d21fac6

2 files changed

Lines changed: 2 additions & 12 deletions

File tree

app/src/main/java/org/schabi/newpipe/fragments/list/playlist/PlaylistFragment.java

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
import android.view.MenuItem;
1414
import android.view.View;
1515
import android.view.ViewGroup;
16-
import android.widget.Toast;
1716

1817
import androidx.annotation.NonNull;
1918
import androidx.annotation.Nullable;
@@ -231,13 +230,8 @@ public boolean onOptionsItemSelected(final MenuItem item) {
231230
ShareUtils.openUrlInBrowser(requireContext(), url);
232231
break;
233232
case R.id.menu_item_share:
234-
if (currentInfo != null) {
235-
ShareUtils.shareText(requireContext(), name, url,
236-
currentInfo.getThumbnailUrl());
237-
} else {
238-
Toast.makeText(getContext(), getString(R.string.playlist_loading_message),
239-
Toast.LENGTH_SHORT).show();
240-
}
233+
ShareUtils.shareText(requireContext(), name, url,
234+
currentInfo == null ? null : currentInfo.getThumbnailUrl());
241235
break;
242236
case R.id.menu_item_bookmark:
243237
onBookmarkClicked();
@@ -253,9 +247,6 @@ public boolean onOptionsItemSelected(final MenuItem item) {
253247
.collect(Collectors.toList()),
254248
dialog -> dialog.show(getFM(), TAG)
255249
));
256-
} else {
257-
Toast.makeText(getContext(), getString(R.string.playlist_loading_message),
258-
Toast.LENGTH_SHORT).show();
259250
}
260251
break;
261252
default:

app/src/main/res/values/strings.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,6 @@
241241
<string name="restore_defaults">Restore defaults</string>
242242
<string name="restore_defaults_confirmation">Do you want to restore defaults?</string>
243243
<string name="permission_display_over_apps">Give permission to display over other apps</string>
244-
<string name="playlist_loading_message">Playlist loading…</string>
245244
<!-- error activity -->
246245
<string name="error_report_notification_title">NewPipe encountered an error, tap to report</string>
247246
<string name="error_report_notification_toast">An error occurred, see the notification</string>

0 commit comments

Comments
 (0)