Rename dummy_* and more to placeholder_*

Author: Stypox

app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java

@@ -1552,7 +1552,7 @@ public void handleResult(@NonNull final StreamInfo info) {
         }
 
         final Drawable buddyDrawable
-                = AppCompatResources.getDrawable(activity, R.drawable.dummy_person);
+                = AppCompatResources.getDrawable(activity, R.drawable.placeholder_person);
         binding.detailSubChannelThumbnailView.setImageDrawable(buddyDrawable);
         binding.detailUploaderThumbnailView.setImageDrawable(buddyDrawable);
 

app/src/main/java/org/schabi/newpipe/local/dialog/PlaylistAppendDialog.java

@@ -145,7 +145,8 @@ private void onPlaylistSelected(@NonNull final LocalPlaylistManager manager,
         final Toast successToast = Toast.makeText(getContext(),
                 R.string.playlist_add_stream_success, Toast.LENGTH_SHORT);
 
-        if (playlist.thumbnailUrl.equals("drawable://" + R.drawable.dummy_thumbnail_playlist)) {
+        if (playlist.thumbnailUrl
+                .equals("drawable://" + R.drawable.placeholder_thumbnail_playlist)) {
             playlistDisposables.add(manager
                     .changePlaylistThumbnail(playlist.uid, streams.get(0).getThumbnailUrl())
                     .observeOn(AndroidSchedulers.mainThread())

app/src/main/java/org/schabi/newpipe/local/playlist/LocalPlaylistFragment.java

@@ -613,7 +613,7 @@ private void updateThumbnailUrl() {
             newThumbnailUrl = ((PlaylistStreamEntry) itemListAdapter.getItemsList().get(0))
                     .getStreamEntity().getThumbnailUrl();
         } else {
-            newThumbnailUrl = "drawable://" + R.drawable.dummy_thumbnail_playlist;
+            newThumbnailUrl = "drawable://" + R.drawable.placeholder_thumbnail_playlist;
         }
 
         changeThumbnailUrl(newThumbnailUrl);

app/src/main/java/org/schabi/newpipe/player/Player.java

@@ -3108,7 +3108,7 @@ public String getUploaderName() {
     public Bitmap getThumbnail() {
         if (currentThumbnail == null) {
             currentThumbnail = BitmapFactory.decodeResource(
-                    context.getResources(), R.drawable.dummy_thumbnail);
+                    context.getResources(), R.drawable.placeholder_thumbnail_video);
         }
         return currentThumbnail;
     }

app/src/main/java/org/schabi/newpipe/util/PicassoHelper.java

@@ -97,23 +97,23 @@ public static boolean getShouldLoadImages() {
 
 
     public static RequestCreator loadAvatar(final String url) {
-        return loadImageDefault(url, R.drawable.dummy_person);
+        return loadImageDefault(url, R.drawable.placeholder_person);
     }
 
     public static RequestCreator loadThumbnail(final String url) {
-        return loadImageDefault(url, R.drawable.dummy_thumbnail);
+        return loadImageDefault(url, R.drawable.placeholder_thumbnail_video);
     }
 
     public static RequestCreator loadDetailsThumbnail(final String url) {
-        return loadImageDefault(url, R.drawable.dummy_thumbnail, false);
+        return loadImageDefault(url, R.drawable.placeholder_thumbnail_video, false);
     }
 
     public static RequestCreator loadBanner(final String url) {
-        return loadImageDefault(url, R.drawable.channel_banner);
+        return loadImageDefault(url, R.drawable.placeholder_channel_banner);
     }
 
     public static RequestCreator loadPlaylistThumbnail(final String url) {
-        return loadImageDefault(url, R.drawable.dummy_thumbnail_playlist);
+        return loadImageDefault(url, R.drawable.placeholder_thumbnail_playlist);
     }
 
     public static RequestCreator loadSeekbarThumbnailPreview(final String url) {

…in/res/drawable-nodpi/channel_banner.png …ble-nodpi/placeholder_channel_banner.pngapp/src/main/res/drawable-nodpi/channel_banner.png renamed to app/src/main/res/drawable-nodpi/placeholder_channel_banner.png app/src/main/res/drawable-nodpi/channel_banner.png renamed to app/src/main/res/drawable-nodpi/placeholder_channel_banner.png

@@ -57,7 +57,7 @@
                             android:scaleType="fitCenter"
                             tools:ignore="RtlHardcoded"
                             tools:layout_height="200dp"
-                            tools:src="@drawable/dummy_thumbnail" />
+                            tools:src="@drawable/placeholder_thumbnail_video" />
 
                         <ImageView
                             android:id="@+id/detail_thumbnail_play_button"
@@ -271,7 +271,7 @@
                                         android:layout_width="@dimen/video_item_detail_uploader_image_size"
                                         android:layout_height="@dimen/video_item_detail_uploader_image_size"
                                         android:contentDescription="@string/detail_uploader_thumbnail_view_description"
-                                        android:src="@drawable/dummy_person"
+                                        android:src="@drawable/placeholder_person"
                                         app:shapeAppearance="@style/CircularImageView" />
 
                                     <com.google.android.material.imageview.ShapeableImageView
@@ -280,7 +280,7 @@
                                         android:layout_height="@dimen/video_item_detail_sub_channel_image_size"
                                         android:layout_gravity="bottom|right"
                                         android:contentDescription="@string/detail_sub_channel_thumbnail_view_description"
-                                        android:src="@drawable/dummy_person"
+                                        android:src="@drawable/placeholder_person"
                                         android:visibility="gone"
                                         app:shapeAppearance="@style/CircularImageView"
                                         tools:visibility="visible" />
@@ -645,7 +645,7 @@
             android:paddingLeft="@dimen/video_item_search_padding"
             android:paddingRight="@dimen/video_item_search_padding"
             android:scaleType="fitCenter"
-            android:src="@drawable/dummy_thumbnail" />
+            android:src="@drawable/placeholder_thumbnail_video" />
 
         <LinearLayout
             android:id="@+id/overlay_metadata_layout"