Skip to content

Commit 3e15c77

Browse files
committed
move string to donottranslate.xml and fix nits
1 parent 50269d0 commit 3e15c77

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

app/src/main/java/org/schabi/newpipe/download/DownloadDialog.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -566,8 +566,6 @@ public void onItemSelected(final AdapterView<?> parent,
566566
}
567567

568568
private void onItemSelectedSetFileName() {
569-
final String setSubtitleLanguageCode = subtitleStreamsAdapter.getItem(selectedSubtitleIndex)
570-
.getLanguageTag();
571569
final String fileName = FilenameUtils.createFilename(getContext(),
572570
currentInfo.getName());
573571
switch (dialogBinding.videoAudioGroup.getCheckedRadioButtonId()) {
@@ -576,7 +574,9 @@ private void onItemSelectedSetFileName() {
576574
dialogBinding.fileName.setText(fileName);
577575
break;
578576
case R.id.subtitle_button:
579-
dialogBinding.fileName.setText(fileName + getString(
577+
final String setSubtitleLanguageCode = subtitleStreamsAdapter
578+
.getItem(selectedSubtitleIndex).getLanguageTag();
579+
dialogBinding.fileName.setText(getString(
580580
R.string.caption_file_name, fileName, setSubtitleLanguageCode));
581581
break;
582582
}

app/src/main/res/values/donottranslate.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,4 +27,5 @@
2727
<string name="soundcloud">SoundCloud</string>
2828
<string name="preferred_open_action_share_menu_title">@string/app_name</string>
2929
<string name="leakcanary">LeakCanary</string>
30+
<string name="caption_file_name">%1$s-%2$s</string>
3031
</resources>

app/src/main/res/values/strings.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -452,7 +452,6 @@
452452
<string name="resize_zoom">Zoom</string>
453453
<string name="caption_auto_generated">Auto-generated</string>
454454
<!-- Caption Settings -->
455-
<string name="caption_file_name">%1$s-%2$s</string>
456455
<string name="caption_setting_title">Captions</string>
457456
<string name="caption_setting_description">Modify player caption text scale and background styles. Requires app restart to take effect</string>
458457
<!-- Debug Settings -->

0 commit comments

Comments
 (0)