Skip to content

Commit 2bf58ab

Browse files
committed
Make miniplayer close button area larger
1 parent 2984649 commit 2bf58ab

2 files changed

Lines changed: 30 additions & 31 deletions

File tree

app/src/main/res/layout-large-land/fragment_video_detail.xml

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -603,19 +603,19 @@
603603
android:id="@+id/view_pager"
604604
android:layout_width="match_parent"
605605
android:layout_height="match_parent"
606-
app:layout_behavior="@string/appbar_scrolling_view_behavior"
607-
android:paddingBottom="48dp"/>
606+
android:paddingBottom="48dp"
607+
app:layout_behavior="@string/appbar_scrolling_view_behavior" />
608608

609609
<com.google.android.material.tabs.TabLayout
610610
android:id="@+id/tab_layout"
611611
android:layout_width="match_parent"
612612
android:layout_height="wrap_content"
613613
android:layout_gravity="bottom|center"
614-
app:tabIndicatorGravity="top"
615-
app:tabIconTint="?attr/colorAccent"
614+
app:elevation="16dp"
616615
app:tabBackground="?attr/windowBackground"
617616
app:tabGravity="fill"
618-
app:elevation="16dp"/>
617+
app:tabIconTint="?attr/colorAccent"
618+
app:tabIndicatorGravity="top" />
619619

620620
</org.schabi.newpipe.views.FocusAwareCoordinator>
621621

@@ -627,6 +627,7 @@
627627
android:layout_weight="3" />
628628
</LinearLayout>
629629

630+
630631
<RelativeLayout
631632
android:id="@+id/overlay_layout"
632633
android:layout_width="match_parent"
@@ -657,6 +658,7 @@
657658
android:focusable="true"
658659
android:gravity="center_vertical"
659660
android:orientation="vertical"
661+
android:theme="@style/ContrastTintTheme"
660662
tools:ignore="RtlHardcoded">
661663

662664
<org.schabi.newpipe.views.NewPipeTextView
@@ -694,16 +696,15 @@
694696
android:layout_height="60dp"
695697
android:layout_alignParentEnd="true"
696698
android:gravity="center_vertical"
697-
android:paddingLeft="@dimen/video_item_search_padding"
698-
android:paddingRight="@dimen/video_item_search_padding"
699+
android:theme="@style/ContrastTintTheme"
699700
tools:ignore="RtlHardcoded">
700701

701702
<ImageButton
702703
android:id="@+id/overlay_play_queue_button"
703704
android:layout_width="40dp"
704705
android:layout_height="match_parent"
705706
android:background="?attr/selectableItemBackground"
706-
android:padding="10dp"
707+
android:contentDescription="@string/title_activity_play_queue"
707708
android:scaleType="center"
708709
android:src="@drawable/ic_list"
709710
tools:ignore="ContentDescription,RtlHardcoded" />
@@ -713,22 +714,22 @@
713714
android:layout_width="40dp"
714715
android:layout_height="match_parent"
715716
android:background="?attr/selectableItemBackground"
716-
android:padding="10dp"
717-
android:scaleType="center"
717+
android:contentDescription="@string/pause"
718718
android:focusable="true"
719719
android:focusedByDefault="true"
720-
android:src="@drawable/ic_play_arrow"
721-
tools:ignore="ContentDescription,RtlHardcoded" />
720+
android:scaleType="center"
721+
android:src="@drawable/ic_play_arrow" />
722722

723723
<ImageButton
724724
android:id="@+id/overlay_close_button"
725-
android:layout_width="40dp"
725+
android:layout_width="48dp"
726726
android:layout_height="match_parent"
727727
android:background="?attr/selectableItemBackground"
728-
android:padding="10dp"
728+
android:contentDescription="@string/close"
729+
android:paddingRight="8dp"
729730
android:scaleType="center"
730731
android:src="@drawable/ic_close"
731-
tools:ignore="ContentDescription,RtlHardcoded" />
732+
tools:ignore="RtlSymmetry" />
732733

733734
</LinearLayout>
734735

app/src/main/res/layout/fragment_video_detail.xml

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,9 @@
4141
android:id="@+id/detail_thumbnail_image_view"
4242
android:layout_width="match_parent"
4343
android:layout_height="wrap_content"
44-
android:minHeight="200dp"
4544
android:background="?windowBackground"
4645
android:contentDescription="@string/detail_thumbnail_view_description"
46+
android:minHeight="200dp"
4747
android:scaleType="fitCenter"
4848
tools:ignore="RtlHardcoded"
4949
tools:layout_height="200dp"
@@ -586,19 +586,19 @@
586586
android:id="@+id/view_pager"
587587
android:layout_width="match_parent"
588588
android:layout_height="match_parent"
589-
app:layout_behavior="@string/appbar_scrolling_view_behavior"
590-
android:paddingBottom="48dp"/>
589+
android:paddingBottom="48dp"
590+
app:layout_behavior="@string/appbar_scrolling_view_behavior" />
591591

592592
<com.google.android.material.tabs.TabLayout
593593
android:id="@+id/tab_layout"
594594
android:layout_width="match_parent"
595595
android:layout_height="wrap_content"
596596
android:layout_gravity="bottom|center"
597-
app:tabIndicatorGravity="top"
598-
app:tabIconTint="?attr/colorAccent"
597+
app:elevation="16dp"
599598
app:tabBackground="?attr/windowBackground"
600599
app:tabGravity="fill"
601-
app:elevation="16dp"/>
600+
app:tabIconTint="?attr/colorAccent"
601+
app:tabIndicatorGravity="top" />
602602

603603
</androidx.coordinatorlayout.widget.CoordinatorLayout>
604604

@@ -668,8 +668,6 @@
668668
android:layout_height="60dp"
669669
android:layout_alignParentEnd="true"
670670
android:gravity="center_vertical"
671-
android:paddingLeft="@dimen/video_item_search_padding"
672-
android:paddingRight="@dimen/video_item_search_padding"
673671
android:theme="@style/ContrastTintTheme"
674672
tools:ignore="RtlHardcoded">
675673

@@ -678,7 +676,7 @@
678676
android:layout_width="40dp"
679677
android:layout_height="match_parent"
680678
android:background="?attr/selectableItemBackground"
681-
android:padding="10dp"
679+
android:contentDescription="@string/title_activity_play_queue"
682680
android:scaleType="center"
683681
android:src="@drawable/ic_list"
684682
tools:ignore="ContentDescription,RtlHardcoded" />
@@ -688,22 +686,22 @@
688686
android:layout_width="40dp"
689687
android:layout_height="match_parent"
690688
android:background="?attr/selectableItemBackground"
691-
android:padding="10dp"
692-
android:scaleType="center"
689+
android:contentDescription="@string/pause"
693690
android:focusable="true"
694691
android:focusedByDefault="true"
695-
android:src="@drawable/ic_play_arrow"
696-
tools:ignore="ContentDescription,RtlHardcoded" />
692+
android:scaleType="center"
693+
android:src="@drawable/ic_play_arrow" />
697694

698695
<ImageButton
699696
android:id="@+id/overlay_close_button"
700-
android:layout_width="40dp"
697+
android:layout_width="48dp"
701698
android:layout_height="match_parent"
702699
android:background="?attr/selectableItemBackground"
703-
android:padding="10dp"
700+
android:contentDescription="@string/close"
701+
android:paddingRight="8dp"
704702
android:scaleType="center"
705703
android:src="@drawable/ic_close"
706-
tools:ignore="ContentDescription,RtlHardcoded" />
704+
tools:ignore="RtlSymmetry" />
707705

708706
</LinearLayout>
709707

0 commit comments

Comments
 (0)