use strict; use warnings; everywhere

karenetheridge · karenetheridge · commit 4fde9ad8bf07 · 2015-07-08T17:23:53.000-07:00
diff --git a/Makefile.PL b/Makefile.PL
@@ -2,8 +2,9 @@
 
 require 5.008001;
 use strict;
-use ExtUtils::MakeMaker;
+use warnings;
 
+use ExtUtils::MakeMaker;
 
 WriteMakefile(
     NAME => 'HTTP::Message',
diff --git a/lib/HTTP/Config.pm b/lib/HTTP/Config.pm
@@ -1,6 +1,8 @@
 package HTTP::Config;
 
 use strict;
+use warnings;
+
 use URI;
 
 our $VERSION = "6.07";
diff --git a/lib/HTTP/Headers.pm b/lib/HTTP/Headers.pm
@@ -1,6 +1,8 @@
 package HTTP::Headers;
 
 use strict;
+use warnings;
+
 use Carp ();
 
 our $VERSION = "6.07";
diff --git a/lib/HTTP/Headers/Auth.pm b/lib/HTTP/Headers/Auth.pm
@@ -1,6 +1,7 @@
 package HTTP::Headers::Auth;
 
 use strict;
+use warnings;
 
 our $VERSION = "6.07";
 
diff --git a/lib/HTTP/Headers/ETag.pm b/lib/HTTP/Headers/ETag.pm
@@ -1,6 +1,7 @@
 package HTTP::Headers::ETag;
 
 use strict;
+use warnings;
 
 our $VERSION = "6.07";
 
diff --git a/lib/HTTP/Headers/Util.pm b/lib/HTTP/Headers/Util.pm
@@ -1,6 +1,7 @@
 package HTTP::Headers::Util;
 
 use strict;
+use warnings;
 
 our $VERSION = "6.07";
 
diff --git a/lib/HTTP/Message.pm b/lib/HTTP/Message.pm
@@ -1,6 +1,7 @@
 package HTTP::Message;
 
 use strict;
+use warnings;
 
 our $VERSION = "6.07";
 
diff --git a/lib/HTTP/Request.pm b/lib/HTTP/Request.pm
@@ -1,6 +1,7 @@
 package HTTP::Request;
 
 use strict;
+use warnings;
 
 use base 'HTTP::Message';
 
diff --git a/lib/HTTP/Request/Common.pm b/lib/HTTP/Request/Common.pm
@@ -1,6 +1,7 @@
 package HTTP::Request::Common;
 
 use strict;
+use warnings;
 
 our $DYNAMIC_FILE_UPLOAD ||= 0;  # make it defined (don't know why)
 
diff --git a/lib/HTTP/Response.pm b/lib/HTTP/Response.pm
@@ -1,6 +1,7 @@
 package HTTP::Response;
 
 use strict;
+use warnings;
 
 use base 'HTTP::Message';
 
diff --git a/lib/HTTP/Status.pm b/lib/HTTP/Status.pm
@@ -1,6 +1,8 @@
 package HTTP::Status;
 
 use strict;
+use warnings;
+
 require 5.002;   # because we use prototypes
 
 use base 'Exporter';
diff --git a/t/common-req.t b/t/common-req.t
@@ -1,11 +1,14 @@
 #perl -w
 
+use strict;
+use warnings;
+
 use Test;
 plan tests => 58;
 
 use HTTP::Request::Common;
 
-$r = GET 'http://www.sn.no/';
+my $r = GET 'http://www.sn.no/';
 print $r->as_string;
 
 ok($r->method, "GET");
@@ -85,7 +88,7 @@ ok($r->content_type, "text/plain");
 #
 # POST for File upload
 #
-$file = "test-$$";
+my $file = "test-$$";
 open(FILE, ">$file") or die "Can't create $file: $!";
 print FILE "foo\nbar\nbaz\n";
 close(FILE);
@@ -105,12 +108,12 @@ unlink($file) or warn "Can't unlink $file: $!";
 ok($r->method, "POST");
 ok($r->uri->path, "/survey.cgi");
 ok($r->content_type, "multipart/form-data");
-ok($r->header(Content_type) =~ /boundary="?([^"]+)"?/);
-$boundary = $1;
+ok($r->header('Content_type') =~ /boundary="?([^"]+)"?/);
+my $boundary = $1;
 
-$c = $r->content;
+my $c = $r->content;
 $c =~ s/\r//g;
-@c = split(/--\Q$boundary/, $c);
+my @c = split(/--\Q$boundary/, $c);
 print "$c[5]\n";
 
 ok(@c == 7 and $c[6] =~ /^--\n/);  # 5 parts + header & trailer
@@ -175,13 +178,13 @@ print $r->as_string, "\n";
 ok($r->method, "POST");
 ok($r->uri->path, "/survey.cgi");
 ok($r->content_type, "multipart/form-data");
-ok($r->header(Content_type) =~ /boundary="?([^"]+)"?/);
+ok($r->header('Content_type') =~ /boundary="?([^"]+)"?/);
 $boundary = $1;
 ok(ref($r->content), "CODE");
 
 ok(length($boundary) > 10);
 
-$code = $r->content;
+my $code = $r->content;
 my $chunk;
 my @chunks;
 while (defined($chunk = &$code) && length $chunk) {
diff --git a/t/headers-auth.t b/t/headers-auth.t
@@ -1,6 +1,8 @@
 #!perl -w
 
 use strict;
+use warnings;
+
 use Test;
 
 plan tests => 6;
diff --git a/t/headers-etag.t b/t/headers-etag.t
@@ -1,6 +1,8 @@
 #!perl -w
 
 use strict;
+use warnings;
+
 use Test;
 
 plan tests => 4;
diff --git a/t/headers-util.t b/t/headers-util.t
@@ -1,6 +1,8 @@
 #!perl -w
 
 use strict;
+use warnings;
+
 use Test;
 
 use HTTP::Headers::Util qw(split_header_words join_header_words);
diff --git a/t/headers.t b/t/headers.t
@@ -1,6 +1,8 @@
 #!perl -w
 
 use strict;
+use warnings;
+
 use Test qw(plan ok);
 
 plan tests => 175;
diff --git a/t/http-config.t b/t/http-config.t
@@ -1,6 +1,8 @@
 #!perl -w
 
 use strict;
+use warnings;
+
 use Test;
 plan tests => 14;
 
diff --git a/t/message-charset.t b/t/message-charset.t
@@ -1,6 +1,7 @@
 #!perl -w
 
 use strict;
+use warnings;
 
 use Test;
 plan tests => 43;
diff --git a/t/message-old.t b/t/message-old.t
@@ -5,6 +5,8 @@
 # add new tests to message.t instead.
 
 use strict;
+use warnings;
+
 use Test qw(plan ok);
 
 plan tests => 20;
diff --git a/t/message-parts.t b/t/message-parts.t
@@ -1,6 +1,8 @@
 #!/usr/bin/perl -w
 
 use strict;
+use warnings;
+
 use Test qw(plan ok);
 plan tests => 47;
 
diff --git a/t/message.t b/t/message.t
@@ -1,6 +1,8 @@
 #!perl -w
 
 use strict;
+use warnings;
+
 use Test qw(plan ok skip);
 
 plan tests => 129;
diff --git a/t/request.t b/t/request.t
@@ -2,6 +2,7 @@
 # message.t test suite.
 
 use strict;
+use warnings;
 
 use Test;
 plan tests => 11;
diff --git a/t/response.t b/t/response.t
@@ -4,6 +4,8 @@
 # message.t test suite.
 
 use strict;
+use warnings;
+
 use Test;
 plan tests => 23;
 
diff --git a/t/status-old.t b/t/status-old.t
@@ -1,5 +1,8 @@
 #!perl -w
 
+use strict;
+use warnings;
+
 use Test;
 plan tests => 8;
 
diff --git a/t/status.t b/t/status.t
@@ -1,5 +1,8 @@
 #!perl -w
 
+use strict;
+use warnings;
+
 use Test;
 plan tests => 10;
 
