From 42ad6c5095ee478c4f20278ad4450ee3fbf3be99 Mon Sep 17 00:00:00 2001 From: Ragnarok <260221049+librerob@users.noreply.github.com> Date: Mon, 19 Oct 2026 16:50:46 +0000 Subject: [PATCH] Watch Adwaita folder artwork and Nemo integration upstreams --- maintenance/README.md | 20 +++++++++++++++++--- maintenance/upstream-watch.json | 31 +++++++++++++++++++++++++++++++ tests/test_upstream_watch.py | 16 ++++++++++++++++ 3 files changed, 64 insertions(+), 3 deletions(-) diff --git a/maintenance/README.md b/maintenance/README.md index 2e53b8b..cf9c9d8 100644 --- a/maintenance/README.md +++ b/maintenance/README.md @@ -21,11 +21,11 @@ updates. API/configuration failures fail the workflow and must not be read as The catalog tracks GTK3, current/future GTK majors, libadwaita, GNOME desktop release manifests, current/future GNOME Shell majors, the supported Shell 46 maintenance series, Cinnamon, Muffin, Xfce panel, Xfwm4 integration, MATE desktop, -Marco and Budgie. It uses the projects' public upstream GitHub repositories or +Marco, Budgie, Adwaita Icon Theme and Nemo. It uses the projects' public upstream GitHub repositories or mirrors. Primary GitLab releases may reach a mirror later. Baseline versions come from [the compatibility review](../COMPATIBILITY.md) -and the pinned Shell metadata. A baseline records the last review point; it +and the pinned Shell/icon metadata. A baseline records the last review point; it is not a claim that every desktop session or future point release is tested. The MATE desktop baseline is the beginning of the reviewed 1.28 series; Marco has its separate, specifically tested version. @@ -37,10 +37,24 @@ libadwaita, Cinnamon/Muffin, Xfce and MATE/Marco use explicitly configured even minor series; Budgie and modern GNOME Shell do not. Minor versions 90 and above are excluded as development versions. These are conservative **tag rules**, not a substitute for reading official release announcements. A project changing -its release scheme may require updating the rules. Pinned Shell tag commit +its release scheme may require updating the rules. Pinned Shell/icon tag commit changes are flagged, and missing baseline tags or incomplete pagination produce errors rather than a green “no-new-tag” result. +## Adwaita folder artwork + +The icon watch starts at the imported Adwaita Icon Theme 51.0 commit recorded +in `icons/UPSTREAM.md`. Recoloring preserves the upstream shapes, so changes to +folder SVG geometry, folder names/aliases and license notices can matter. +Upstream inheritance or symbolic-icon changes can also affect icons inherited +at runtime. An update confined to unrelated application artwork may need no +local change. The watch does not import icons or change icon inheritance. + +Nemo is watched separately because our GTK3 theme includes custom rules for its +desktop rename entries and icon-container states. Other application extras stay +covered by their parser/rendering tests; every application release does not +need to become a theme-maintenance alert. + ## Reviewing an update 1. Follow the comparison and source links. Read NEWS/release notes and changes diff --git a/maintenance/upstream-watch.json b/maintenance/upstream-watch.json index c51b15c..85f18be 100644 --- a/maintenance/upstream-watch.json +++ b/maintenance/upstream-watch.json @@ -197,6 +197,37 @@ "", "v" ] + }, + { + "id": "adwaita-icons", + "name": "Adwaita Icon Theme (folder source and fallback)", + "repo": "GNOME/adwaita-icon-theme", + "baseline_tag": "51.0", + "baseline_commit": "70ecd52fbe844304ed4f845a04a1757fa6284884", + "path": "Adwaita/scalable/places", + "focus": "Review full-color folder SVGs, new/renamed folder aliases, index.theme inheritance, symbolic lookup and license notices. Application-icon-only changes may not need a theme update. Do not change artwork or inheritance automatically.", + "tests": "tools/generate_icons.py --check, tests/test_icons.py, all-accent native GTK/Qt icon lookup/render tests and representative file-manager checks.", + "even_minor": false, + "min_major": 40, + "prefixes": [ + "", + "v" + ] + }, + { + "id": "nemo", + "name": "Nemo (application-specific GTK integration)", + "repo": "linuxmint/nemo", + "baseline_tag": "6.6.4", + "path": "src", + "focus": "Review desktop/icon-container rename entries, selection/context menus and CSS-node/style-class changes used by our Nemo-specific rules. Unrelated features do not imply a theme change.", + "tests": "GTK3 parsing, Nemo inline-rename regression and tests/filemanager_icons.py across accents; confirm real selection/context-menu behavior.", + "even_minor": true, + "min_major": 6, + "prefixes": [ + "", + "v" + ] } ] } diff --git a/tests/test_upstream_watch.py b/tests/test_upstream_watch.py index d28d262..9840b6a 100644 --- a/tests/test_upstream_watch.py +++ b/tests/test_upstream_watch.py @@ -34,6 +34,22 @@ def test_numeric_versions_and_development_filters(self): shell = next(x for x in self.catalog['components'] if x['id'] == 'shell46') self.assertEqual(watch.inspect_component(shell, [tag('46.10', shell['baseline_commit']), tag('51.1')])['latest'], '46.10') + def test_icon_release_filter_and_pinned_source_changes(self): + icons = next(x for x in self.catalog['components'] if x['id'] == 'adwaita-icons') + tags = [tag('51.0', icons['baseline_commit']), tag('52.alpha'), tag('51.90'), tag('52.0')] + result = watch.inspect_component(icons, tags) + self.assertEqual(result['latest'], '52.0') + self.assertEqual(result['status'], 'review-needed') + self.assertFalse(result['baseline_commit_changed']) + result = watch.inspect_component(icons, [tag('51.0', 'b' * 40)]) + self.assertTrue(result['baseline_commit_changed']) + self.assertIn(icons['baseline_commit'], result['compare_url']) + + def test_nemo_ignores_development_series_and_branch_build_tags(self): + nemo = next(x for x in self.catalog['components'] if x['id'] == 'nemo') + tags = [tag(x) for x in ('6.6.4', '6.7.1', 'master.mint27', '6.8.0')] + self.assertEqual(watch.inspect_component(nemo, tags)['latest'], '6.8.0') + def test_complete_pagination_does_not_assume_api_order(self): calls = [] def fetch(repo, page):