Skip to content

Commit a8e021d

Browse files
committed
fix: pin Meshery UI to pre-upgrade commit to restore integration test
Meshery UI's master is broken after upgrading to @mui/x-tree-view@v8 (meshery/meshery#18163) which removed the TreeView export, while their component code still imports from '@mui/x-tree-view/TreeView'. Pin to the last known-good commit until Meshery UI fixes the migration. Signed-off-by: Yi Nuo <218099172+yi-nuo426@users.noreply.github.com>
1 parent f0bc673 commit a8e021d

File tree

1 file changed

+4
-21
lines changed

1 file changed

+4
-21
lines changed

.github/workflows/test-meshery-integration.yml

Lines changed: 4 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,10 @@ jobs:
5151
uses: actions/checkout@v6
5252
with:
5353
repository: meshery/meshery
54+
# Pin to last known-good commit before the @mui/x-tree-view v8 upgrade
55+
# that broke the TreeView import (meshery/meshery#18163).
56+
# Update this ref once Meshery UI fixes the migration.
57+
ref: 7c3d02c91365dc776b11ffc50aab277026e86701
5458
path: meshery
5559
fetch-depth: 1
5660

@@ -62,27 +66,6 @@ jobs:
6266
working-directory: meshery/ui
6367
run: npm install ../../sistent/${{ env.SISTENT_PACKAGE }}
6468

65-
- name: Patch Meshery UI for Next.js 16.x compatibility
66-
working-directory: meshery/ui
67-
run: |
68-
# Add ignoreDeprecations for TypeScript 6.x baseUrl deprecation
69-
if [ -f tsconfig.json ] && grep -q '"baseUrl"' tsconfig.json && ! grep -q '"ignoreDeprecations"' tsconfig.json; then
70-
sed -i 's/"compilerOptions"\s*:\s*{/"compilerOptions": {\n "ignoreDeprecations": "6.0",/' tsconfig.json
71-
echo "Patched tsconfig.json to add ignoreDeprecations: 6.0"
72-
fi
73-
# Patch package.json build script to use --webpack for Next.js 16 compatibility
74-
if [ -f package.json ] && grep -q '"build"' package.json && ! grep -q -- '--webpack' package.json; then
75-
node -e "
76-
const fs = require('fs');
77-
const pkg = JSON.parse(fs.readFileSync('package.json', 'utf8'));
78-
if (pkg.scripts && pkg.scripts.build) {
79-
pkg.scripts.build = pkg.scripts.build.replace('next build', 'next build --webpack');
80-
fs.writeFileSync('package.json', JSON.stringify(pkg, null, 2));
81-
console.log('Patched build script to use webpack mode');
82-
}
83-
"
84-
fi
85-
8669
- name: Build Meshery UI
8770
working-directory: meshery/ui
8871
run: |

0 commit comments

Comments
 (0)