Skip to content

Commit 8e3149e

Browse files
committed
fix: resolve CI failures for lint and Meshery UI integration test
Remove stale eslint-disable comment referencing unregistered import/first rule that was causing ESLint to fail with reportUnusedDisableDirectives. Patch Meshery UI tsconfig in integration test to add ignoreDeprecations: "6.0" so builds with TypeScript 6.x (bundled with Next.js 16.x) continue to work. Signed-off-by: Yi Nuo <218099172+yi-nuo426@users.noreply.github.com>
1 parent 339824c commit 8e3149e

2 files changed

Lines changed: 15 additions & 1 deletion

File tree

.github/workflows/test-meshery-integration.yml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,21 @@ jobs:
6262
working-directory: meshery/ui
6363
run: npm install ../../sistent/${{ env.SISTENT_PACKAGE }}
6464

65+
- name: Patch Meshery UI tsconfig for TypeScript 6.x compatibility
66+
working-directory: meshery/ui
67+
run: |
68+
if [ -f tsconfig.json ] && grep -q '"baseUrl"' tsconfig.json; then
69+
node -e "
70+
const fs = require('fs');
71+
const tsconfig = JSON.parse(fs.readFileSync('tsconfig.json', 'utf8'));
72+
if (tsconfig.compilerOptions && !tsconfig.compilerOptions.ignoreDeprecations) {
73+
tsconfig.compilerOptions.ignoreDeprecations = '6.0';
74+
fs.writeFileSync('tsconfig.json', JSON.stringify(tsconfig, null, 2));
75+
console.log('Patched tsconfig.json to add ignoreDeprecations: 6.0');
76+
}
77+
"
78+
fi
79+
6580
- name: Build Meshery UI
6681
working-directory: meshery/ui
6782
run: |

src/__testing__/ResponsiveDataTable.test.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ jest.mock('@sistent/mui-datatables', () => {
5050
};
5151
});
5252

53-
// eslint-disable-next-line import/first
5453
import ResponsiveDataTable from '../custom/ResponsiveDataTable';
5554

5655
const mockColumns = [

0 commit comments

Comments
 (0)