From aa1af5b354d8fc14fd5d939bf2f079c74032fc51 Mon Sep 17 00:00:00 2001
From: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Date: Wed, 28 Oct 2026 09:15:05 -0400
Subject: [PATCH] [scanner] fix: stabilize allClusters in
 useUpgradeStateMachine test to stop render loop

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
---
 web/src/hooks/__tests__/useUpgradeStateMachine.test.tsx | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/web/src/hooks/__tests__/useUpgradeStateMachine.test.tsx b/web/src/hooks/__tests__/useUpgradeStateMachine.test.tsx
index 28d01d70dc..32753b8e66 100644
--- a/web/src/hooks/__tests__/useUpgradeStateMachine.test.tsx
+++ b/web/src/hooks/__tests__/useUpgradeStateMachine.test.tsx
@@ -450,8 +450,11 @@ describe('useUpgradeStateMachine — Cleanup', () => {
 
   describe('loading state exposure', () => {
     it('exposes fetchCompleted state (loading indicator) to consumers', () => {
+      // Stable reference: an inline [] is a new dep every render, and the hook's
+      // not-connected branch always calls setState, so it re-rendered forever (#24572).
+      const noClusters: ClusterInfo[] = []
       const { result } = renderHook(() => useUpgradeStateMachine({
-        allClusters: [],
+        allClusters: noClusters,
         agentConnected: false,
         isDemoMode: false,
         openTrackedWs: vi.fn(),