pre-push hook is broken

[Kevlar]

What happened:

$ git push personal
.git/hooks/pre-push: line 11: ./verify/verify-boilerplate.sh: No such file or directory

What you expected to happen:
Successful execution of pre-push hook

How to reproduce it (as minimally and precisely as possible):

$ git clone git@github.com:kubernetes/perf-tests.git
$ cd perf-tests
$ cp _hook/pre-push .git/hooks/pre-push
$ git remote add <remote name> <somewhere you have permission to push>
$ git push <above remote name>

Anything else we need to know?:

Environment:

• Kubernetes version (use kubectl version): n/a
• Cloud provider or hardware configuration: n/a
• OS (e.g: cat /etc/os-release): Ubuntu 24.04.2 LTS
• Kernel (e.g. uname -a): 6.11.0-26-generic
• Install tools: git
• Network plugin and version (if this is a network-related bug): n/a
• Others:

[Kevlar]

It looks like this is running into:

1. Pathing issues - we use:
   GIT_ROOT=$(dirname "${BASH_SOURCE[0]}")/../
   to path vs something robust to where it is run like:
   GIT_ROOT=$(git rev-parse --show-toplevel)

2. Outdated verify script names:
   It looks like pre-push points to:
   ./verify/verify-golint.sh
   which looks like it was removed here in May 2020

[yanghanlin]

The pre-push script also references ./verify/verify-gofmt.sh, which is no longer available either.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[yanghanlin]

/remove-lifecycle stale
This is still relevant.

[Kevlar]

@yanghanlin I was never able to get any engagement on this. I tried poking people on slack too, but no one ever responded.

I had made this to get everything working for my system:
https://github.com/Kevlar/perf-tests/tree/hooks_patch

I'd hoped to have a few interactions to polish it to the point to get a PR out, but gave up after a few weeks of attempted engagement.

If you know how to get people engaged to wrap this up, I'd be happy to resurrect my environment and clean things up.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten