Add excludedInstanceTypes to instanceRequirements

When defining instanceRequirements in the mixedInstancesPolicy for an
instance group, allow defining a list of instance types that can be
excluded from the set of eligible instances using a new
excludedInstanceTypes field.

Author: jim-barber-he

docs/instance_groups.md

@@ -294,6 +294,24 @@ spec:
 
 Note that burstable instances are always included in the set of eligible instances.
 
+You can exclude instance types from the set of eligible instances using `excludedInstanceTypes`.
+You can use strings with one or more wild cards, represented by an asterisk (*), to exclude an instance type, size, or generation.
+For example, `m7i.8xlarge`, `c7*.*`, `m7a.*`, `r*`, `*3*`.
+
+```
+spec:
+  mixedInstancesPolicy:
+    instanceRequirements:
+      cpu:
+        min: "2"
+        max: "16"
+      memory:
+        min: "2G"
+      excludedInstanceTypes:
+      - t2.*
+      - t3.*
+```
+
 ## warmPool (AWS Only)
 
 {{ kops_feature_table(kops_added_default='1.21') }}

k8s/crds/kops.k8s.io_instancegroups.yaml

@@ -939,6 +939,14 @@ spec:
                             pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
                             x-kubernetes-int-or-string: true
                         type: object
+                      excludedInstanceTypes:
+                        description: |-
+                          ExcludedInstanceTypes is a list of instance types which will not be used by the instance group.
+                          You can use strings with one or more wild cards, represented by an asterisk (*), to exclude an
+                          instance type, size, or generation.
+                        items:
+                          type: string
+                        type: array
                       memory:
                         properties:
                           max:

pkg/apis/kops/instancegroup.go

@@ -279,6 +279,10 @@ type MixedInstancesPolicySpec struct {
 type InstanceRequirementsSpec struct {
 	CPU    *MinMaxSpec `json:"cpu,omitempty"`
 	Memory *MinMaxSpec `json:"memory,omitempty"`
+	// ExcludedInstanceTypes is a list of instance types which will not be used by the instance group.
+	// You can use strings with one or more wild cards, represented by an asterisk (*), to exclude an
+	// instance type, size, or generation.
+	ExcludedInstanceTypes []string `json:"excludedInstanceTypes,omitempty"`
 }
 
 type MinMaxSpec struct {

pkg/apis/kops/v1alpha2/instancegroup.go

@@ -225,6 +225,10 @@ type MixedInstancesPolicySpec struct {
 type InstanceRequirementsSpec struct {
 	CPU    *MinMaxSpec `json:"cpu,omitempty"`
 	Memory *MinMaxSpec `json:"memory,omitempty"`
+	// ExcludedInstanceTypes is a list of instance types which will not be used by the instance group.
+	// You can use strings with one or more wild cards, represented by an asterisk (*), to exclude an
+	// instance type, size, or generation.
+	ExcludedInstanceTypes []string `json:"excludedInstanceTypes,omitempty"`
 }
 
 type MinMaxSpec struct {

pkg/apis/kops/v1alpha2/zz_generated.conversion.go

@@ -218,6 +218,10 @@ type MixedInstancesPolicySpec struct {
 type InstanceRequirementsSpec struct {
 	CPU    *MinMaxSpec `json:"cpu,omitempty"`
 	Memory *MinMaxSpec `json:"memory,omitempty"`
+	// ExcludedInstanceTypes is a list of instance types which will not be used by the instance group.
+	// You can use strings with one or more wild cards, represented by an asterisk (*), to exclude an
+	// instance type, size, or generation.
+	ExcludedInstanceTypes []string `json:"excludedInstanceTypes,omitempty"`
 }
 
 type MinMaxSpec struct {