Skip to content

Commit a825f4d

Browse files
authored
Merge pull request #18131 from rifelpet/do-csi-e2e
do: Upgrade CSI and enable E2E
2 parents 68b3e73 + 5adc258 commit a825f4d

5 files changed

Lines changed: 431 additions & 96 deletions

File tree

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
# Manifest for Kubernetes external tests.
2+
# See https://github.com/kubernetes/kubernetes/tree/master/test/e2e/storage/external
3+
# https://github.com/digitalocean/csi-digitalocean/blob/master/test/e2e/testdrivers/1.35.yaml
4+
StorageClass:
5+
FromFile: tests/e2e/csi-manifests/dobs/sc.yaml
6+
SnapshotClass:
7+
FromName: true
8+
DriverInfo:
9+
Name: dobs.csi.digitalocean.com
10+
SupportedSizeRange:
11+
Max: 100Gi
12+
Min: 1Gi
13+
Capabilities:
14+
persistence: true
15+
block: true
16+
fsGroup: true
17+
volumeMountGroup: false
18+
exec: true
19+
snapshotDataSource: true
20+
pvcDataSource: false
21+
multipods: true
22+
RWX: false
23+
controllerExpansion: true
24+
nodeExpansion: true
25+
onlineExpansion: true
26+
volumeLimits: true
27+
singleNodeVolume: true
28+
topology: true
29+
capacity: false
30+
SupportedFsType:
31+
ext3:
32+
ext4:
33+
xfs:
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
apiVersion: storage.k8s.io/v1
2+
kind: StorageClass
3+
metadata:
4+
name: do-block-storage
5+
allowVolumeExpansion: true
6+
provisioner: dobs.csi.digitalocean.com
7+
reclaimPolicy: Delete
8+
volumeBindingMode: Immediate

tests/e2e/csi-manifests/manifests.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,5 +18,5 @@ package csimanifests
1818

1919
import "embed"
2020

21-
//go:embed aws-ebs/* gcp-pd/*
21+
//go:embed aws-ebs/* gcp-pd/* dobs/*
2222
var FS embed.FS

tests/e2e/pkg/tester/tester.go

Lines changed: 19 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -424,19 +424,21 @@ func (t *Tester) addCSIDriverFlags() error {
424424
}
425425

426426
var provider, migratedPlugin string
427-
if cluster.Spec.CloudConfig != nil {
428-
switch {
429-
case cluster.Spec.CloudConfig.AWSEBSCSIDriver != nil &&
430-
cluster.Spec.CloudConfig.AWSEBSCSIDriver.Enabled != nil &&
431-
*cluster.Spec.CloudConfig.AWSEBSCSIDriver.Enabled:
432-
provider = "aws-ebs"
433-
migratedPlugin = "kubernetes.io/aws-ebs"
434-
case cluster.Spec.CloudConfig.GCPPDCSIDriver != nil &&
435-
cluster.Spec.CloudConfig.GCPPDCSIDriver.Enabled != nil &&
436-
*cluster.Spec.CloudConfig.GCPPDCSIDriver.Enabled:
437-
provider = "gcp-pd"
438-
migratedPlugin = "kubernetes.io/gce-pd"
439-
}
427+
switch {
428+
case cluster.Spec.CloudConfig != nil &&
429+
cluster.Spec.CloudConfig.AWSEBSCSIDriver != nil &&
430+
cluster.Spec.CloudConfig.AWSEBSCSIDriver.Enabled != nil &&
431+
*cluster.Spec.CloudConfig.AWSEBSCSIDriver.Enabled:
432+
provider = "aws-ebs"
433+
migratedPlugin = "kubernetes.io/aws-ebs"
434+
case cluster.Spec.CloudConfig != nil &&
435+
cluster.Spec.CloudConfig.GCPPDCSIDriver != nil &&
436+
cluster.Spec.CloudConfig.GCPPDCSIDriver.Enabled != nil &&
437+
*cluster.Spec.CloudConfig.GCPPDCSIDriver.Enabled:
438+
provider = "gcp-pd"
439+
migratedPlugin = "kubernetes.io/gce-pd"
440+
case cluster.Spec.LegacyCloudProvider == "digitalocean":
441+
provider = "dobs"
440442
}
441443

442444
if provider == "" {
@@ -474,7 +476,10 @@ func (t *Tester) addCSIDriverFlags() error {
474476
return fmt.Errorf("writing driver.yaml: %w", err)
475477
}
476478

477-
driverFlags := fmt.Sprintf(" --storage.testdriver=%s --storage.migratedPlugins=%s", driverPath, migratedPlugin)
479+
driverFlags := fmt.Sprintf(" --storage.testdriver=%s", driverPath)
480+
if migratedPlugin != "" {
481+
driverFlags += fmt.Sprintf(" --storage.migratedPlugins=%s", migratedPlugin)
482+
}
478483
klog.Infof("Setting %v", driverFlags)
479484
t.TestArgs += driverFlags
480485
return nil

0 commit comments

Comments
 (0)