azure: Fix disk deletion loop during cluster teardown

Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>

Author: hakman

pkg/resources/azure/azure.go

@@ -19,6 +19,7 @@ package azure
 import (
 	"context"
 	"fmt"
+	"strings"
 
 	"github.com/Azure/azure-sdk-for-go/sdk/azcore/arm"
 	authz "github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/authorization/armauthorization/v3"
@@ -80,11 +81,14 @@ func (g *resourceGetter) listResourcesAzure() (map[string]*resources.Resource, e
 	}
 
 	// Convert a slice of resources to a map of resources keyed by type and ID.
+	// Normalize IDs to lowercase since Azure resource IDs are case-insensitive
+	// but different Azure APIs may return different casing for the same resource.
 	resources := make(map[string]*resources.Resource)
 	for _, r := range rs {
 		if r.Done {
 			continue
 		}
+		r.ID = strings.ToLower(r.ID)
 		resources[toKey(r.Type, r.ID)] = r
 	}
 	return resources, nil
@@ -780,5 +784,5 @@ func (g *resourceGetter) isOwnedByCluster(tags map[string]*string) bool {
 }
 
 func toKey(rtype, id string) string {
-	return rtype + ":" + id
+	return rtype + ":" + strings.ToLower(id)
 }

upup/pkg/fi/cloudup/azure/disk.go

@@ -51,7 +51,7 @@ func (c *disksClientImpl) CreateOrUpdate(ctx context.Context, resourceGroupName,
 
 func (c *disksClientImpl) List(ctx context.Context, resourceGroupName string) ([]*compute.Disk, error) {
 	var l []*compute.Disk
-	pager := c.c.NewListPager(nil)
+	pager := c.c.NewListByResourceGroupPager(resourceGroupName, nil)
 	for pager.More() {
 		resp, err := pager.NextPage(ctx)
 		if err != nil {