Skip to content

Commit ca0589d

Browse files
committed
Minor naming fixes
1 parent 7b0de93 commit ca0589d

1 file changed

Lines changed: 17 additions & 15 deletions

File tree

ThermiaOnlineAPI/model/HeatPump.py

Lines changed: 17 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -443,7 +443,7 @@ def __get_all_operational_statuses_from_operational_status(
443443
if data is None:
444444
return ChainMap()
445445

446-
operation_modes_map = map(
446+
operation_statuses_map = map(
447447
lambda values: {
448448
values.get("value"): {
449449
"name": values.get("name").split(
@@ -455,8 +455,8 @@ def __get_all_operational_statuses_from_operational_status(
455455
data,
456456
)
457457

458-
operation_modes_list = list(operation_modes_map)
459-
return ChainMap(*operation_modes_list)
458+
operation_statuses_list = list(operation_statuses_map)
459+
return ChainMap(*operation_statuses_list)
460460

461461
def __get_all_visible_operational_statuses_from_operational_status(
462462
self,
@@ -466,15 +466,17 @@ def __get_all_visible_operational_statuses_from_operational_status(
466466
if data is None:
467467
return ChainMap()
468468

469-
operation_modes_map = map(
469+
operation_statuses_map = map(
470470
lambda item: (
471471
{item[0]: item[1].get("name")} if item[1].get("visible") else {}
472472
),
473473
data.items(),
474474
)
475475

476-
operation_modes_list = list(filter(lambda x: x != {}, operation_modes_map))
477-
return ChainMap(*operation_modes_list)
476+
operation_statuses_list = list(
477+
filter(lambda x: x != {}, operation_statuses_map)
478+
)
479+
return ChainMap(*operation_statuses_list)
478480

479481
def __get_running_operational_statuses(
480482
self,
@@ -514,7 +516,7 @@ def __get_running_operational_statuses(
514516
):
515517
# Attempt to get multiple statuses by binary sum of the values
516518
data_items_list.sort(key=lambda x: x[0], reverse=True)
517-
list_of_current_operation_modes = []
519+
list_of_current_operation_statuses = []
518520

519521
if self.__device_config["operational_status_minRegisterValue"] is not None:
520522
current_register_value -= int(
@@ -525,10 +527,10 @@ def __get_running_operational_statuses(
525527
if key <= current_register_value:
526528
current_register_value -= key
527529
if value.get("visible"):
528-
list_of_current_operation_modes.append(value.get("name"))
530+
list_of_current_operation_statuses.append(value.get("name"))
529531

530532
if current_register_value == 0:
531-
return list_of_current_operation_modes
533+
return list_of_current_operation_statuses
532534

533535
return []
534536

@@ -548,7 +550,7 @@ def __get_all_power_statuses_from_power_status(
548550
if data is None:
549551
return ChainMap()
550552

551-
power_modes_map = map(
553+
power_statuses_map = map(
552554
lambda values: {
553555
values.get("value"): {
554556
"name": values.get("name").split("COMP_VALUE_STEP_")[1],
@@ -558,8 +560,8 @@ def __get_all_power_statuses_from_power_status(
558560
data,
559561
)
560562

561-
power_modes_list = list(power_modes_map)
562-
return ChainMap(*power_modes_list)
563+
power_statuses_list = list(power_statuses_map)
564+
return ChainMap(*power_statuses_list)
563565

564566
def __get_all_visible_power_statuses_from_power_status(
565567
self,
@@ -569,15 +571,15 @@ def __get_all_visible_power_statuses_from_power_status(
569571
if data is None:
570572
return ChainMap()
571573

572-
power_modes_map = map(
574+
power_statuses_map = map(
573575
lambda item: (
574576
{item[0]: item[1].get("name")} if item[1].get("visible") else {}
575577
),
576578
data.items(),
577579
)
578580

579-
power_modes_list = list(filter(lambda x: x != {}, power_modes_map))
580-
return ChainMap(*power_modes_list)
581+
power_statuses_list = list(filter(lambda x: x != {}, power_statuses_map))
582+
return ChainMap(*power_statuses_list)
581583

582584
def __get_running_power_statuses(
583585
self,

0 commit comments

Comments
 (0)