test(ethereum): cover full-width token chain IDs

Author: BitHighlander

scripts/generate-test-report.py

@@ -1158,19 +1158,29 @@ def junit_cases(path):
           'Ethereum transfer chain/asset binding',
           'The first asset approval changes between Ethereum, BNB Chain and Polygon.',
           ['ETH, BNB and MATIC approval sequences']),
-         ('R18', 'test_msg_osmosis_validation',
+         ('R18', 'test_msg_ethereum_signtx',
+          'test_ethereum_erc20_high_chain_id_does_not_alias_mainnet',
+          'ERC-20 chain-ID width binding',
+          'Chain 257 cannot borrow chain-1 token labels or decimals.',
+          ['Chain 1 and chain 257 approval sequences']),
+         ('R19', 'test_msg_ethereum_signtx_xfer',
+          'test_erc20_transfer_high_chain_id_does_not_alias_mainnet',
+          'ERC-20 transfer chain-ID width binding',
+          'TRANSFER review scopes token metadata to the complete chain ID.',
+          ['Chain 1 and chain 257 transfer sequences']),
+         ('R20', 'test_msg_osmosis_validation',
           'test_present_but_empty_amount_is_rejected_before_review',
           'Osmosis empty amount refusal', 'Present-but-empty is not displayed as zero.', []),
-         ('R19', 'test_msg_osmosis_validation',
+         ('R21', 'test_msg_osmosis_validation',
           'test_ibc_omitted_amount_and_receiver_are_rejected_before_review',
           'Osmosis IBC required fields', 'Omitted value and receiver are refused.', []),
-         ('R20', 'test_msg_recoverydevice_cipher',
+         ('R22', 'test_msg_recoverydevice_cipher',
           'test_unknown_word_count_failure_aborts_recovery',
           'Recovery Failure is terminal', 'A stale CharacterAck cannot resume the ceremony.', []),
-         ('R21', 'test_msg_signing_boundaries',
+         ('R23', 'test_msg_signing_boundaries',
           'test_multisig_signature_over_72_bytes_is_rejected',
           'Multisig serialization bound', 'Oversized host signatures are refused.', []),
-         ('R22', 'test_msg_signing_boundaries',
+         ('R24', 'test_msg_signing_boundaries',
           'test_clear_session_aborts_active_bitcoin_signing',
           'ClearSession ends signing', 'A stale TxAck cannot resume the signer.', []),
      ]),

tests/test_msg_ethereum_signtx.py

@@ -27,9 +27,42 @@
 import keepkeylib.types_pb2 as proto_types
 from keepkeylib.client import CallException
 from keepkeylib.tools import int_to_big_endian
+from test_msg_display_disclosure import ScreenRecorder
 
 
 class TestMsgEthereumSigntx(common.KeepKeyTest):
+    def test_ethereum_erc20_high_chain_id_does_not_alias_mainnet(self):
+        """Chain 257 must not borrow chain-1 token labels or decimals."""
+        self.requires_firmware("7.14.2")
+        self.requires_fullFeature()
+        self.setup_mnemonic_nopin_nopassphrase()
+        self.client.apply_policy("AdvancedMode", 1)
+
+        recipient = self.client.ethereum_get_address([0, 0])
+        erc20_data = (
+            binascii.unhexlify("a9059cbb" + "00" * 12) +
+            recipient + int_to_big_endian(1).rjust(32, b"\x00")
+        )
+        contract = binascii.unhexlify(
+            "d0d6d6c5fe4a677d343cc433536bb717bae167dd"
+        )
+
+        first_screens = {}
+        try:
+            for chain_id in (1, 257):
+                with ScreenRecorder(self.client) as recorder:
+                    self.client.ethereum_sign_tx(
+                        n=[0, 0], nonce=0, gas_price=20, gas_limit=60000,
+                        to=contract, value=0, chain_id=chain_id,
+                        data=erc20_data,
+                    )
+                self.assertGreaterEqual(len(recorder.screens), 2)
+                first_screens[chain_id] = recorder.screens[0]
+        finally:
+            self.client.apply_policy("AdvancedMode", 0)
+
+        self.assertNotEqual(first_screens[1], first_screens[257])
+
     def test_ethereum_unrenderable_amounts_are_rejected(self):
         """Neither a native nor ERC-20 amount may reach an approval blank."""
         self.requires_firmware("7.14.2")

tests/test_msg_ethereum_signtx_xfer.py

@@ -62,6 +62,42 @@ def test_transfer_review_uses_signing_chain_asset(self):
 
         self.client.apply_policy('ShapeShift', 0)
 
+    def test_erc20_transfer_high_chain_id_does_not_alias_mainnet(self):
+        """TRANSFER review must not borrow chain-1 token metadata."""
+        self.requires_firmware("7.14.2")
+        self.requires_fullFeature()
+        self.setup_mnemonic_nopin_nopassphrase()
+        self.client.apply_policy('ShapeShift', 1)
+        self.client.apply_policy('AdvancedMode', 1)
+
+        destination_n = [0x8000002c, 0x8000003c, 0x80000001, 0, 0]
+        recipient = self.client.ethereum_get_address(destination_n)
+        erc20_data = (
+            binascii.unhexlify("a9059cbb" + "00" * 12) +
+            recipient + int_to_big_endian(1).rjust(32, b"\x00")
+        )
+        contract = binascii.unhexlify(
+            "d0d6d6c5fe4a677d343cc433536bb717bae167dd"
+        )
+
+        first_screens = {}
+        try:
+            for chain_id in (1, 257):
+                with ScreenRecorder(self.client) as recorder:
+                    self.client.ethereum_sign_tx(
+                        n=[0, 0], nonce=0, gas_price=20, gas_limit=60000,
+                        value=0, to=contract, to_n=destination_n,
+                        address_type=proto_types.TRANSFER,
+                        data=erc20_data, chain_id=chain_id,
+                    )
+                self.assertGreaterEqual(len(recorder.screens), 2)
+                first_screens[chain_id] = recorder.screens[0]
+        finally:
+            self.client.apply_policy('AdvancedMode', 0)
+            self.client.apply_policy('ShapeShift', 0)
+
+        self.assertNotEqual(first_screens[1], first_screens[257])
+
     def test_ethereum_tx_xfer_acc1(self):
         self.requires_fullFeature()
         self.setup_mnemonic_nopin_nopassphrase()