Skip to content

Commit 54908ab

Browse files
committed
fix(types): align rule context usage with ESLint 10 typings
- route filename/sourceCode access through util helpers for ESLint 7/10 compatibility - remove deprecated meta.docs.category to satisfy current RuleModule typings - augment @eslint/core SettingsConfig with react settings shape
1 parent 9932114 commit 54908ab

5 files changed

Lines changed: 22 additions & 3 deletions

File tree

lib/rules/forward-ref-uses-ref.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
const isParenthesized = require('../util/ast').isParenthesized;
88
const docsUrl = require('../util/docsUrl');
9+
const getSourceCode = require('../util/eslint').getSourceCode;
910
const report = require('../util/report');
1011
const getMessageData = require('../util/message');
1112

@@ -57,7 +58,7 @@ module.exports = {
5758
},
5859

5960
create(context) {
60-
const sourceCode = context.getSourceCode();
61+
const sourceCode = getSourceCode(context);
6162

6263
return {
6364
'FunctionExpression, ArrowFunctionExpression'(node) {

lib/rules/jsx-filename-extension.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
const path = require('path');
99
const docsUrl = require('../util/docsUrl');
10+
const getFilename = require('../util/eslint').getFilename;
1011
const report = require('../util/report');
1112

1213
// ------------------------------------------------------------------------------
@@ -61,7 +62,7 @@ module.exports = {
6162
},
6263

6364
create(context) {
64-
const filename = context.filename || context.getFilename();
65+
const filename = getFilename(context);
6566

6667
let jsxNode;
6768

lib/util/eslint.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@ function getSourceCode(context) {
44
return context.getSourceCode ? context.getSourceCode() : context.sourceCode;
55
}
66

7+
function getFilename(context) {
8+
return context.filename || context.getFilename();
9+
}
10+
711
function getAncestors(context, node) {
812
const sourceCode = getSourceCode(context);
913
return sourceCode.getAncestors ? sourceCode.getAncestors(node) : context.getAncestors();
@@ -38,6 +42,7 @@ function getText(context) {
3842

3943
module.exports = {
4044
getAncestors,
45+
getFilename,
4146
getFirstTokens,
4247
getScope,
4348
getSourceCode,

lib/util/makeNoMethodSetStateRule.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ module.exports = function makeNoMethodSetStateRule(methodName, shouldCheckUnsafe
5555
meta: {
5656
docs: {
5757
description: `Disallow usage of setState in ${methodName}`,
58-
category: 'Best Practices',
5958
recommended: false,
6059
url: docsUrl(mapTitle(methodName)),
6160
},

types/eslint-core-augment.d.ts

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
import '@eslint/core';
2+
3+
declare module '@eslint/core' {
4+
interface SettingsConfig {
5+
react?: {
6+
pragma?: string;
7+
fragment?: string;
8+
createClass?: string;
9+
};
10+
}
11+
}
12+
13+
export {};

0 commit comments

Comments
 (0)