Skip to content

Commit c2b3ebb

Browse files
timmywiltimmywil
authored
fix(ie): set IEDriver location in GitHub Actions (#21)
- given the recent [issues with IEDriver](jquery/jquery#5723) in all jQuery projects, set the default IE driver location manually and add a test to run jQuery in Edge in IE mode in CI. - update submodules - remove the need for a special jtr-test branch in each submodule - upgrade dependencies - update Node in workflows to 24.x, the latest LTS - fix an issue with the most recent version of exit-hook. See sindresorhus/exit-hook#42
1 parent 027671a commit c2b3ebb

13 files changed

Lines changed: 1536 additions & 2608 deletions

‎.github/workflows/jquery-migrate.yml‎

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
name: jQuery Migrate
22

33
on:
4-
pull_request:
54
push:
6-
branches:
7-
- main
5+
branches: [ "main" ]
6+
pull_request:
7+
branches: [ "main" ]
88

99
env:
10-
NODE_VERSION: 22.x
10+
NODE_VERSION: 24.x
1111

1212
jobs:
1313
build-and-test:
@@ -23,18 +23,20 @@ jobs:
2323
uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0
2424
with:
2525
node-version: ${{ env.NODE_VERSION }}
26-
27-
- name: Cache
28-
uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
29-
with:
30-
path: ~/.npm
31-
key: ${{ runner.os }}-node-${{ env.NODE_VERSION }}-npm-lock-${{ hashFiles('**/package-lock.json') }}
32-
restore-keys: |
33-
${{ runner.os }}-node-${{ env.NODE_VERSION }}-npm-lock-
26+
cache: npm
27+
cache-dependency-path: '**/package-lock.json'
3428

3529
- name: Install dependencies
36-
run: npm install
30+
run: npm ci
31+
32+
- name: Install jQuery Migrate dependencies
33+
working-directory: test/jquery-migrate
34+
run: npm ci
35+
36+
- name: Install local JTR
37+
working-directory: test/jquery-migrate
38+
run: npm install -D ../../
3739

3840
- name: Run jQuery Migrate tests
3941
working-directory: test/jquery-migrate
40-
run: npm it
42+
run: npm test

‎.github/workflows/jquery-mousewheel.yml‎

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
name: jQuery Mousewheel
22

33
on:
4-
pull_request:
54
push:
6-
branches:
7-
- main
5+
branches: [ "main" ]
6+
pull_request:
7+
branches: [ "main" ]
88

99
env:
10-
NODE_VERSION: 22.x
10+
NODE_VERSION: 24.x
1111

1212
jobs:
1313
build-and-test:
@@ -23,18 +23,20 @@ jobs:
2323
uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0
2424
with:
2525
node-version: ${{ env.NODE_VERSION }}
26-
27-
- name: Cache
28-
uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
29-
with:
30-
path: ~/.npm
31-
key: ${{ runner.os }}-node-${{ env.NODE_VERSION }}-npm-lock-${{ hashFiles('**/package-lock.json') }}
32-
restore-keys: |
33-
${{ runner.os }}-node-${{ env.NODE_VERSION }}-npm-lock-
26+
cache: npm
27+
cache-dependency-path: '**/package-lock.json'
3428

3529
- name: Install dependencies
36-
run: npm install
30+
run: npm ci
31+
32+
- name: Install jQuery Mousewheel dependencies
33+
working-directory: test/jquery-mousewheel
34+
run: npm ci
35+
36+
- name: Install local JTR
37+
working-directory: test/jquery-mousewheel
38+
run: npm install -D ../../
3739

3840
- name: Run jQuery Mousewheel tests
3941
working-directory: test/jquery-mousewheel
40-
run: npm it
42+
run: npm test

‎.github/workflows/jquery-ui.yml‎

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
name: jQuery UI
22

33
on:
4-
pull_request:
54
push:
6-
branches:
7-
- main
5+
branches: [ "main" ]
6+
pull_request:
7+
branches: [ "main" ]
88

99
env:
10-
NODE_VERSION: 22.x
10+
NODE_VERSION: 24.x
1111

1212
jobs:
1313
build-and-test:
@@ -23,18 +23,20 @@ jobs:
2323
uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0
2424
with:
2525
node-version: ${{ env.NODE_VERSION }}
26-
27-
- name: Cache
28-
uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
29-
with:
30-
path: ~/.npm
31-
key: ${{ runner.os }}-node-${{ env.NODE_VERSION }}-npm-lock-${{ hashFiles('**/package-lock.json') }}
32-
restore-keys: |
33-
${{ runner.os }}-node-${{ env.NODE_VERSION }}-npm-lock-
26+
cache: npm
27+
cache-dependency-path: '**/package-lock.json'
3428

3529
- name: Install dependencies
36-
run: npm install
30+
run: npm ci
31+
32+
- name: Install jQuery UI dependencies
33+
working-directory: test/jquery-ui
34+
run: npm ci
35+
36+
- name: Install local JTR
37+
working-directory: test/jquery-ui
38+
run: npm install -D ../../
3739

3840
- name: Run jQuery UI tests
3941
working-directory: test/jquery-ui
40-
run: npm it
42+
run: npm test

‎.github/workflows/jquery.yml‎

Lines changed: 42 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
name: jQuery
22

33
on:
4-
pull_request:
54
push:
6-
branches:
7-
- main
5+
branches: [ "main" ]
6+
pull_request:
7+
branches: [ "main" ]
88

99
env:
10-
NODE_VERSION: 22.x
10+
NODE_VERSION: 24.x
1111

1212
jobs:
1313
build-and-test:
@@ -23,18 +23,47 @@ jobs:
2323
uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0
2424
with:
2525
node-version: ${{ env.NODE_VERSION }}
26+
cache: npm
27+
cache-dependency-path: '**/package-lock.json'
28+
29+
- name: Install dependencies
30+
run: npm ci
31+
32+
- name: Install jQuery dependencies
33+
working-directory: test/jquery
34+
run: npm ci
2635

27-
- name: Cache
28-
uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
36+
- name: Install local JTR
37+
working-directory: test/jquery
38+
run: npm install -D ../../
39+
40+
- name: Run jQuery tests
41+
working-directory: test/jquery
42+
run: npm run test:browser -- -v
43+
44+
ie:
45+
runs-on: windows-latest
46+
name: Test jQuery with IEDriver
47+
steps:
48+
- name: Checkout
49+
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
2950
with:
30-
path: ~/.npm
31-
key: ${{ runner.os }}-node-${{ env.NODE_VERSION }}-npm-lock-${{ hashFiles('**/package-lock.json') }}
32-
restore-keys: |
33-
${{ runner.os }}-node-${{ env.NODE_VERSION }}-npm-lock-
51+
submodules: recursive
52+
53+
- name: Use Node.js ${{ env.NODE_VERSION }}
54+
uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0
55+
with:
56+
node-version: ${{ env.NODE_VERSION }}
57+
cache: npm
58+
cache-dependency-path: '**/package-lock.json'
3459

3560
- name: Install dependencies
36-
run: npm install
61+
run: npm ci
3762

38-
- name: Run jQuery tests
63+
- name: Install local JTR
64+
working-directory: test/jquery
65+
run: npm install -D ../../
66+
67+
- name: Run jQuery tests in Edge in IE mode
3968
working-directory: test/jquery
40-
run: npm install && npm run test:browser -- -v
69+
run: npm run test:ie -- -v

‎.github/workflows/test.yml‎

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,25 @@ on:
66
pull_request:
77
branches: [ "main" ]
88

9+
env:
10+
NODE_VERSION: 24.x
11+
912
jobs:
1013
test:
1114
runs-on: ubuntu-latest
1215
steps:
1316
- name: Checkout
1417
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
1518

19+
- name: Use Node.js ${{ env.NODE_VERSION }}
20+
uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0
21+
with:
22+
node-version: ${{ env.NODE_VERSION }}
23+
cache: npm
24+
cache-dependency-path: '**/package-lock.json'
25+
1626
- name: Install dependencies
17-
run: npm install
27+
run: npm ci
1828

1929
- name: Run tests
2030
run: npm test

0 commit comments

Comments
 (0)