Skip to content

Use of general.ignore is not merged with ignore-by-author-name.ignore #555

Description

@CarrotManMatt

I would make an expectation that any rules listed under general.ignore will be ignored in every circumstance. However I have identified that if a commit's author matches ignore-by-author-name.regex then only the rules in ignore-by-author-name.ignore are ignored.

Steps to reproduce

  1. Use the following configuration:
[general]
ignore = B6
regex-style-search = True

[ignore-by-author-name]
regex = \A.*\[bot\].*\Z
ignore = T1,B1
  1. Make a commit with author name renovate[bot] and commit message This is a test0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
  2. Identify that rule T1 (title too long) is successfully ignored, yet rule B6 (missing body )is not ignored, despite it being present in general.ignore

Current workaround

Duplicate any ignored rule identifiers/names that are listed within general.ignore to ignore-by-author-name.ignore so that the rules are ignored under all circumstances.

Requested solution

Merge all necessary ignore fields (including ignore-by-body.ignorr & ignore-by-title.ignore) with general.ignore to remove the need to duplicate requested ignored rules.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions