Commit 2f7a8c2
committed
review PR #564 :
- rename all IGN field names to ign
- fix some spelling and enhance many message comments to not only repeat the message name (could/should be done for 700 as well)
- rollback some dropped but useful comments
- use more templates
- remove minvalue(0) and step(1) when useless
- rollback some message renamings for backwards compatiblity
- drop added "heating" message name prefix as this is expected anyway (cooling is rather the expection)
- removed todos wrt to HA integration
- removed some (ignored) message comments duplications
- commented out some messages with only a hex field and removed some commented parts
* avoid using endlessly long value list for error codes (this would be subject to a translation table on an UI anyway)
- rollback most of the timers layout ("...Write" suffix and dropped "0" suffix of read) and fix the wrong write parts (an extra 00 was part of the id which can't be correct). not sure that removing the 2 other timeslots of each timer/day is the best thing todo though1 parent 16542ac commit 2f7a8c2
1 file changed
Lines changed: 555 additions & 644 deletions
0 commit comments