in misc.c: VA_COPY should not be all-caps

[NHOrus]

stdarg.h contains functions with lower case and is case-sensitive, with Modern C VA_COPY() throws an error due to GCC-14 and Clang-16 disabling long-deprecated C features.

[kseistrup]

I was about to report on the same issue:

---

With gcc 14.1.1 on Linux x86_84 I get the following error:

…/slrn-snapshot/src/slrn-pre1.0.4-9/src/misc.c: In function ‘slrn_verror’:
…/slrn-snapshot/src/slrn-pre1.0.4-9/src/misc.c:376:4: error: implicit declaration of function ‘VA_COPY’ [-Wimplicit-function-declaration]
  376 |    VA_COPY(ap1, ap);
      |    ^~~~~~~

This didn't happen with gcc 13.

If I insert #include "slrnconf.h" between the two upper include statements in misc.c (just to make sure that VA_COPY is defined, as this is most likely not The Right Solution™), the source compiles cleanly, as before.

---

Compiler flags

CPPFLAGS=-D_FORTIFY_SOURCE=3

CFLAGS=-march=x86-64 -mtune=native -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection

LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now -Wl,-z,pack-relative-relocs

LTOFLAGS=-flto=auto

Configure

./configure \
  --prefix=/usr \
  --sysconfdir=/etc \
  --enable-setgid-code \
  --with-canlock \
  --with-canlocklib=/usr/lib \
  --with-canlockinc=/usr/include/libcanlock-3 \
  --without-uu \
  --with-slrnpull \
  --with-ssl \
  --enable-spoilers

[NHOrus]

That works.

--- slrn-1.0.3.orig/src/misc.c  2024-05-11 09:37:44.718954677 -0000
+++ slrn-1.0.3/src/misc.c       2024-05-11 09:37:57.243908388 -0000
@@ -20,6 +20,7 @@
  51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
 */
 #include "config.h"
+#include "slrnconf.h"
 #include "slrnfeat.h"
 
 /*{{{ Include Files */

[kseistrup]

It does work, yes, but it's worth noticing that the first comment in slrnconf.h reads:

#ifndef SLRN_NON_UNIX_CONFIG_H
#define SLRN_NON_UNIX_CONFIG_H
/* 
 * This file is for NON-Unix systems.
 * Use config.h (generated by configure) for Unix!!!
 ⋮

So it's probably more prudent to just add #define VA_COPY va_copy somewhere appropriate.

[kseistrup]

Perhaps this will be fixed by merging pull-request #1.

[NHOrus]

Yeah, that's way better decision.
gentoo/gentoo#36639 adds patch from PR with full attribution but edits for earlier version.

[kseistrup]

Just for the record (and perhaps spare somebody else's time):

I have checked/re-compiled the snapshot versions of:

• jed
• most
• slang
• slxfig

with GCC 14, and they all seem to be unaffected.