fix(codemod): strip trailing YAML closing quote from multi-line notes

The codemod now tracks whether a note was YAML-quoted (single or double)
and strips the trailing closing delimiter from the last continuation line.
This replaces the blunt trailing-quote strip in DocumentBuilder which
was removing legitimate trailing quotes.

Result: 283/289 deep equivalent (up from 278)

Author: ronaldtse

lib/interscript/isc/codemod.rb

@@ -429,6 +429,9 @@ def emit_note_with_continuation(note_indent)
         text = @scanner.scan(/[^\n]+/).to_s
         # Strip YAML inline comments: "text # comment" → "text"
         text = text.sub(/\s+#.*$/, "")
+        # Track if item was YAML-quoted (for trailing quote cleanup)
+        was_dquote = text.start_with?('"') && !text.end_with?('"')
+        was_squote = text.start_with?("'") && !text.end_with?("'")
         # Strip outer quotes if the YAML list item was quoted: - "text"
         text = text[1..-2] if text.start_with?('"') && text.end_with?('"')
         text = text[1..-2] if text.start_with?("'") && text.end_with?("'")
@@ -447,17 +450,26 @@ def emit_note_with_continuation(note_indent)
             @scanner.scan(/\n([ \t]+)/)
             @out << "\\n" + @scanner[1].strip + " "
             cont = @scanner.scan(/[^\n]+/).to_s
-            @out << cont.gsub('\\', '\\\\\\\\').gsub('"', '\\"').gsub("\\u", "\\\\\\\\u")
+            cont = cont.gsub('\\', '\\\\\\\\').gsub('"', '\\"').gsub("\\u", "\\\\\\\\u")
+            @out << cont
           elsif @scanner.check(/\n[ \t]*\n[ \t]{#{note_indent.length + 1},}\S/)
             # Blank line then indented continuation
             @scanner.scan(/\n[ \t]*\n([ \t]+)/)
             @out << "\\n" + @scanner[1].strip + " "
             cont = @scanner.scan(/[^\n]+/).to_s
-            @out << cont.gsub('\\', '\\\\\\\\').gsub('"', '\\"').gsub("\\u", "\\\\\\\\u")
+            cont = cont.gsub('\\', '\\\\\\\\').gsub('"', '\\"').gsub("\\u", "\\\\\\\\u")
+            @out << cont
           else
             break
           end
         end
+        # If item was multi-line YAML-quoted, strip the trailing closing
+        # quote that leaked from the last continuation line.
+        if was_dquote && @out.end_with?('\\"')
+          @out[-2..] = ""
+        elsif was_squote && @out.end_with?("'")
+          @out[-1..] = ""
+        end
         @out << "\""
       end
 

lib/interscript/isc/document_builder.rb

@@ -148,15 +148,11 @@ def extract_metadata(arr)
             h[:notes] ||= []
             Array(field[:notes]).each do |n|
               note_val = n.is_a?(Hash) ? n[:note] : n
-              note_text = normalize_heredoc(unquote(note_val).to_s)
-              note_text = note_text.sub(/["']\z/, "")
-              h[:notes] << note_text
+              h[:notes] << normalize_heredoc(unquote(note_val).to_s)
             end
           when field.key?(:note)
             h[:notes] ||= []
-            note_text = normalize_heredoc(unquote(field[:note]).to_s)
-            note_text = note_text.sub(/["']\z/, "")
-            h[:notes] << note_text
+            h[:notes] << normalize_heredoc(unquote(field[:note]).to_s)
           when field.key?(:provenance)
             h[:provenance] ||= []
             h[:provenance] << unquote(field[:provenance])