From a2c302cd893d8ce292513e61bd59e9001e3531cf Mon Sep 17 00:00:00 2001
From: daveylupes <lupscyber@gmail.com>
Date: Sun, 20 Sep 2026 22:22:35 +0200
Subject: [PATCH] fix(frontend): add confirmation step for asset/peer liquidity
 actions Require review before deposit/withdraw so asset and peer liquidity
 flows meet WCAG 3.3.4, matching existing wallet-address/payment dialogs.

---
 .../app/components/LiquidityConfirmDialog.tsx | 20 ++++++-
 .../app/components/LiquidityDialog.tsx        | 55 +++++++++++--------
 2 files changed, 51 insertions(+), 24 deletions(-)

diff --git a/packages/frontend/app/components/LiquidityConfirmDialog.tsx b/packages/frontend/app/components/LiquidityConfirmDialog.tsx
index 5719bdb4e4..4020a41436 100644
--- a/packages/frontend/app/components/LiquidityConfirmDialog.tsx
+++ b/packages/frontend/app/components/LiquidityConfirmDialog.tsx
@@ -6,13 +6,17 @@ type LiquidityConfirmDialogProps = {
   onClose: () => void
   type: 'Deposit' | 'Withdraw'
   displayAmount: string
+  amount?: string
+  onBack?: () => void
 }
 
 export const LiquidityConfirmDialog = ({
   title,
   onClose,
   type,
-  displayAmount
+  displayAmount,
+  amount,
+  onBack
 }: LiquidityConfirmDialogProps) => {
   return (
     <Dialog.Root open={true} onOpenChange={(open) => !open && onClose()}>
@@ -28,7 +32,21 @@ export const LiquidityConfirmDialog = ({
         </Dialog.Description>
 
         <Form method='post' replace preventScrollReset>
+          {amount !== undefined && (
+            <input type='hidden' name='amount' value={amount} />
+          )}
           <Flex justify='end' gap='3' mt='2'>
+            {onBack && (
+              <Button
+                variant='soft'
+                color='gray'
+                type='button'
+                aria-label={`back to ${type.toLowerCase()} liquidity amount`}
+                onClick={onBack}
+              >
+                Back
+              </Button>
+            )}
             <Dialog.Close>
               <Button
                 variant='soft'
diff --git a/packages/frontend/app/components/LiquidityDialog.tsx b/packages/frontend/app/components/LiquidityDialog.tsx
index edc4963f39..e5a96ba1bb 100644
--- a/packages/frontend/app/components/LiquidityDialog.tsx
+++ b/packages/frontend/app/components/LiquidityDialog.tsx
@@ -1,8 +1,8 @@
-import { Form } from '@remix-run/react'
 import type { ChangeEvent } from 'react'
 import { useEffect, useId, useRef, useState } from 'react'
 import { Button, Dialog, Flex, Text, TextField } from '@radix-ui/themes'
 import { renderFieldError } from '~/lib/form-errors'
+import { LiquidityConfirmDialog } from '~/components/LiquidityConfirmDialog'
 
 type BasicAsset = {
   code: string
@@ -22,8 +22,10 @@ export const LiquidityDialog = ({
   type,
   asset
 }: LiquidityDialogProps) => {
+  const [displayAmount, setDisplayAmount] = useState<string>('')
   const [actualAmount, setActualAmount] = useState<number>(0)
   const [errorMessage, setErrorMessage] = useState<string>('')
+  const [isConfirming, setIsConfirming] = useState<boolean>(false)
   const amountId = useId()
 
   const handleChange = (e: ChangeEvent<HTMLInputElement>) => {
@@ -39,6 +41,7 @@ export const LiquidityDialog = ({
     } else {
       setErrorMessage('')
     }
+    setDisplayAmount(userInput)
     setActualAmount(integerScaledInput)
   }
 
@@ -49,6 +52,19 @@ export const LiquidityDialog = ({
     }
   }, [])
 
+  if (isConfirming) {
+    return (
+      <LiquidityConfirmDialog
+        title={title}
+        onClose={onClose}
+        type={type}
+        displayAmount={`${displayAmount} ${asset.code}`}
+        amount={String(actualAmount)}
+        onBack={() => setIsConfirming(false)}
+      />
+    )
+  }
+
   return (
     <Dialog.Root open={true} onOpenChange={(open) => !open && onClose()}>
       <Dialog.Content style={{ maxWidth: 500 }}>
@@ -77,6 +93,7 @@ export const LiquidityDialog = ({
                 required
                 type='number'
                 name='displayAmount'
+                value={displayAmount}
                 onChange={handleChange}
                 step='any'
                 size='3'
@@ -86,29 +103,21 @@ export const LiquidityDialog = ({
             {renderFieldError(errorMessage)}
           </Flex>
 
-          <Form method='post' replace preventScrollReset>
-            <input
-              required
-              min={1}
-              type='hidden'
-              name='amount'
-              value={actualAmount}
-            />
-            <Flex justify='end' gap='3' mt='2'>
-              <Dialog.Close>
-                <Button variant='soft' color='gray' type='button'>
-                  Cancel
-                </Button>
-              </Dialog.Close>
-              <Button
-                aria-label={`${type} liquidity`}
-                type='submit'
-                disabled={!!errorMessage}
-              >
-                {type} liquidity
+          <Flex justify='end' gap='3' mt='2'>
+            <Dialog.Close>
+              <Button variant='soft' color='gray' type='button'>
+                Cancel
               </Button>
-            </Flex>
-          </Form>
+            </Dialog.Close>
+            <Button
+              aria-label={`review ${type.toLowerCase()} liquidity`}
+              type='button'
+              disabled={!!errorMessage || !(actualAmount >= 1)}
+              onClick={() => setIsConfirming(true)}
+            >
+              Review
+            </Button>
+          </Flex>
         </Flex>
       </Dialog.Content>
     </Dialog.Root>