Improve test isolation and update CI workflows

Removed all existing adapter hooks in test setup methods to ensure tests run in isolation. Updated PHPCS workflow to generate a report file and improved PHPUnit matrix to explicitly test PHP 7.4 with WP 6.5 while running other PHP versions with the latest WP. Enhanced get_channels implementation to append channels to the input array if provided.

Author: pfefferle

.github/workflows/phpcs.yml

@@ -24,4 +24,6 @@ jobs:
         run: composer install --prefer-dist --no-progress
 
       - name: Run PHPCS
-        run: composer lint -- -q --report-checkstyle | cs2pr
+        run: |
+          composer lint -- --report-checkstyle --report-file=phpcs-report.xml || true
+          cs2pr phpcs-report.xml

.github/workflows/phpunit.yml

@@ -11,9 +11,13 @@ jobs:
     runs-on: ubuntu-latest
 
     strategy:
+      fail-fast: false
       matrix:
         php-version: ['7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5']
-        wp-version: ['6.5', 'latest']
+        wp-version: ['latest']
+        include:
+          - php-version: '7.4'
+            wp-version: '6.5'
 
     services:
       mysql:

tests/phpunit/includes/class-test-adapter-implementation.php

@@ -38,16 +38,20 @@ class Test_Adapter_Implementation extends Adapter {
 	 * @return array Channels.
 	 */
 	public function get_channels( $channels, $user_id ) {
-		return array(
-			array(
-				'uid'  => 'notifications',
-				'name' => 'Notifications',
-			),
-			array(
-				'uid'  => 'default',
-				'name' => 'Home',
-			),
+		if ( ! is_array( $channels ) ) {
+			$channels = array();
+		}
+
+		$channels[] = array(
+			'uid'  => 'notifications',
+			'name' => 'Notifications',
 		);
+		$channels[] = array(
+			'uid'  => 'default',
+			'name' => 'Home',
+		);
+
+		return $channels;
 	}
 
 	/**

tests/phpunit/tests/class-test-adapter.php

@@ -31,6 +31,13 @@ class Test_Adapter extends WP_UnitTestCase {
 	 */
 	public function set_up() {
 		parent::set_up();
+		// Remove all existing adapter hooks to test in isolation.
+		remove_all_filters( 'microsub_adapters' );
+		remove_all_filters( 'microsub_get_channels' );
+		remove_all_filters( 'microsub_get_timeline' );
+		remove_all_filters( 'microsub_get_following' );
+		remove_all_filters( 'microsub_follow' );
+		remove_all_filters( 'microsub_unfollow' );
 		$this->adapter = new Test_Adapter_Implementation();
 	}
 

tests/phpunit/tests/class-test-rest-controller.php

@@ -38,6 +38,15 @@ class Test_Rest_Controller extends WP_UnitTestCase {
 	public function set_up() {
 		parent::set_up();
 
+		// Remove all existing adapter hooks to test in isolation.
+		remove_all_filters( 'microsub_adapters' );
+		remove_all_filters( 'microsub_get_channels' );
+		remove_all_filters( 'microsub_get_timeline' );
+		remove_all_filters( 'microsub_get_following' );
+		remove_all_filters( 'microsub_follow' );
+		remove_all_filters( 'microsub_unfollow' );
+		remove_all_filters( 'microsub_timeline_mark_read' );
+
 		global $wp_rest_server;
 		$wp_rest_server = new \WP_REST_Server();
 		$this->server   = $wp_rest_server;