Skip to content

Commit af21983

Browse files
committed
Udpate conditional logic, update YARD comment
1 parent e22e0af commit af21983

3 files changed

Lines changed: 6 additions & 8 deletions

File tree

lib/indieweb/endpoints/parsers/base_parser.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,15 +37,15 @@ def parsed_response_headers
3737
end
3838

3939
def results_from_body
40-
return unless response.mime_type == 'text/html'
40+
return if response.mime_type != 'text/html'
4141

4242
Services::ResponseParserService.parse_body(parsed_response_body, self.class.identifier)
4343
end
4444

4545
def results_from_headers
4646
return if parsed_response_headers.none?
4747

48-
Services::ResponseParserService.parse_headers(parsed_response_headers, self.class.identifier)
48+
Services::ResponseParserService.parse_headers(parsed_response_headers.group_by_relation_type, self.class.identifier)
4949
end
5050

5151
def results_from_http_request

lib/indieweb/endpoints/parsers/redirect_uri_parser.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ class RedirectUriParser < BaseParser
88

99
# @return [Array<String>, nil]
1010
def results
11-
return unless mapped_results.any?
11+
return if mapped_results.none?
1212

1313
mapped_results
1414
end

lib/indieweb/endpoints/services/response_parser_service.rb

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,14 @@ def self.parse_body(body, identifier, node = 'link')
1010
body.css(%(#{node}[rel~="#{identifier}"][href]:not([href*="#"]))).map { |element| element['href'] }
1111
end
1212

13-
# @param headers [LinkHeaderParser::LinkHeadersCollection]
13+
# @param headers [Hash{Symbol => Array<LinkHeaderParser::LinkHeader}]
1414
# @param identifier [Symbol]
1515
# @return [Array<String>, nil]
1616
def self.parse_headers(headers, identifier)
17-
headers_for_identifier = headers.group_by_relation_type[identifier]
18-
19-
return unless headers_for_identifier
17+
return unless headers.key?(identifier)
2018

2119
# Reject endpoints that contain a fragment identifier
22-
headers_for_identifier.reject { |header| Addressable::URI.parse(header.target_uri).fragment }.map(&:target_uri)
20+
headers[identifier].reject { |header| Addressable::URI.parse(header.target_uri).fragment }.map(&:target_uri)
2321
end
2422
end
2523
end

0 commit comments

Comments
 (0)