Address RuboCop concerns about unnecessary symbol conversion

Author: jgarber623

spec/lib/indieweb/endpoints/parsers/authorization_endpoint_parser_spec.rb

@@ -23,7 +23,7 @@
     # Similar to https://webmention.rocks/test/1
     context 'when the HTTP Link header references a relative URL and the `rel` parameter is unquoted' do
       before do
-        stub_request(:get, url).to_return(headers: { 'Link': '</authorization_endpoint>; rel=authorization_endpoint' })
+        stub_request(:get, url).to_return(headers: { Link: '</authorization_endpoint>; rel=authorization_endpoint' })
       end
 
       it 'returns a String' do
@@ -34,7 +34,7 @@
     # Similar to https://webmention.rocks/test/2
     context 'when the HTTP Link header references an absolute URL and the `rel` parameter is unquoted' do
       before do
-        stub_request(:get, url).to_return(headers: { 'Link': %(<#{endpoint}>; rel=authorization_endpoint) })
+        stub_request(:get, url).to_return(headers: { Link: %(<#{endpoint}>; rel=authorization_endpoint) })
       end
 
       it 'returns a String' do
@@ -56,7 +56,7 @@
     # Similar to https://webmention.rocks/test/8
     context 'when the `rel` parameter is quoted' do
       before do
-        stub_request(:get, url).to_return(headers: { 'Link': %(<#{endpoint}>; rel="authorization_endpoint") })
+        stub_request(:get, url).to_return(headers: { Link: %(<#{endpoint}>; rel="authorization_endpoint") })
       end
 
       it 'returns a String' do
@@ -67,7 +67,7 @@
     # Similar to https://webmention.rocks/test/10
     context 'when the `rel` parameter contains multiple space-separated values' do
       before do
-        stub_request(:get, url).to_return(headers: { 'Link': %(<#{endpoint}>; rel="authorization_endpoint somethingelse") })
+        stub_request(:get, url).to_return(headers: { Link: %(<#{endpoint}>; rel="authorization_endpoint somethingelse") })
       end
 
       it 'returns a String' do
@@ -78,7 +78,7 @@
     # Similar to https://webmention.rocks/test/18
     context 'when the response includes multiple HTTP Link headers' do
       before do
-        stub_request(:get, url).to_return(headers: { 'Link': [%(<#{endpoint}#error>; rel="authorization_endpoint"), %(</authorization_endpoint/error>; rel="authorization_endpoint_error"), %(<#{endpoint}>; rel="authorization_endpoint"), '</authorization_endpoint/error>; rel="other"'] })
+        stub_request(:get, url).to_return(headers: { Link: [%(<#{endpoint}#error>; rel="authorization_endpoint"), %(</authorization_endpoint/error>; rel="authorization_endpoint_error"), %(<#{endpoint}>; rel="authorization_endpoint"), '</authorization_endpoint/error>; rel="other"'] })
       end
 
       it 'returns a String' do
@@ -89,7 +89,7 @@
     # Similar to https://webmention.rocks/test/19
     context 'when the HTTP Link header contains multiple comma-separated values' do
       before do
-        stub_request(:get, url).to_return(headers: { 'Link': %(</authorization_endpoint/error>; rel="other", <#{endpoint}>; rel="authorization_endpoint") })
+        stub_request(:get, url).to_return(headers: { Link: %(</authorization_endpoint/error>; rel="other", <#{endpoint}>; rel="authorization_endpoint") })
       end
 
       it 'returns a String' do
@@ -104,9 +104,9 @@
       let(:endpoint) { 'https://example.com/page/authorization_endpoint/endpoint' }
 
       before do
-        stub_request(:get, url).to_return(headers: { 'Location': 'page/authorization_endpoint' }, status: 302)
+        stub_request(:get, url).to_return(headers: { Location: 'page/authorization_endpoint' }, status: 302)
 
-        stub_request(:get, "#{url}/authorization_endpoint").to_return(headers: http_response_headers.merge('Link': "<#{endpoint}>; rel=authorization_endpoint"))
+        stub_request(:get, "#{url}/authorization_endpoint").to_return(headers: http_response_headers.merge(Link: "<#{endpoint}>; rel=authorization_endpoint"))
       end
 
       it 'returns a String' do
@@ -269,7 +269,7 @@
     let(:url) { 'https://example.com/multiple_endpoints' }
 
     before do
-      stub_request(:get, url).to_return(headers: http_response_headers.merge('Link': %(<#{endpoint}>; rel="authorization_endpoint")), body: read_fixture(url))
+      stub_request(:get, url).to_return(headers: http_response_headers.merge(Link: %(<#{endpoint}>; rel="authorization_endpoint")), body: read_fixture(url))
     end
 
     it 'returns a String' do

spec/lib/indieweb/endpoints/parsers/micropub_parser_spec.rb

@@ -23,7 +23,7 @@
     # Similar to https://webmention.rocks/test/1
     context 'when the HTTP Link header references a relative URL and the `rel` parameter is unquoted' do
       before do
-        stub_request(:get, url).to_return(headers: { 'Link': '</micropub>; rel=micropub' })
+        stub_request(:get, url).to_return(headers: { Link: '</micropub>; rel=micropub' })
       end
 
       it 'returns a String' do
@@ -34,7 +34,7 @@
     # Similar to https://webmention.rocks/test/2
     context 'when the HTTP Link header references an absolute URL and the `rel` parameter is unquoted' do
       before do
-        stub_request(:get, url).to_return(headers: { 'Link': %(<#{endpoint}>; rel=micropub) })
+        stub_request(:get, url).to_return(headers: { Link: %(<#{endpoint}>; rel=micropub) })
       end
 
       it 'returns a String' do
@@ -56,7 +56,7 @@
     # Similar to https://webmention.rocks/test/8
     context 'when the `rel` parameter is quoted' do
       before do
-        stub_request(:get, url).to_return(headers: { 'Link': %(<#{endpoint}>; rel="micropub") })
+        stub_request(:get, url).to_return(headers: { Link: %(<#{endpoint}>; rel="micropub") })
       end
 
       it 'returns a String' do
@@ -67,7 +67,7 @@
     # Similar to https://webmention.rocks/test/10
     context 'when the `rel` parameter contains multiple space-separated values' do
       before do
-        stub_request(:get, url).to_return(headers: { 'Link': %(<#{endpoint}>; rel="micropub somethingelse") })
+        stub_request(:get, url).to_return(headers: { Link: %(<#{endpoint}>; rel="micropub somethingelse") })
       end
 
       it 'returns a String' do
@@ -78,7 +78,7 @@
     # Similar to https://webmention.rocks/test/18
     context 'when the response includes multiple HTTP Link headers' do
       before do
-        stub_request(:get, url).to_return(headers: { 'Link': [%(<#{endpoint}#error>; rel="micropub"), %(</micropub/error>; rel="micropub_error"), %(<#{endpoint}>; rel="micropub"), '</micropub/error>; rel="other"'] })
+        stub_request(:get, url).to_return(headers: { Link: [%(<#{endpoint}#error>; rel="micropub"), %(</micropub/error>; rel="micropub_error"), %(<#{endpoint}>; rel="micropub"), '</micropub/error>; rel="other"'] })
       end
 
       it 'returns a String' do
@@ -89,7 +89,7 @@
     # Similar to https://webmention.rocks/test/19
     context 'when the HTTP Link header contains multiple comma-separated values' do
       before do
-        stub_request(:get, url).to_return(headers: { 'Link': %(</micropub/error>; rel="other", <#{endpoint}>; rel="micropub") })
+        stub_request(:get, url).to_return(headers: { Link: %(</micropub/error>; rel="other", <#{endpoint}>; rel="micropub") })
       end
 
       it 'returns a String' do
@@ -104,9 +104,9 @@
       let(:endpoint) { 'https://example.com/page/micropub/endpoint' }
 
       before do
-        stub_request(:get, url).to_return(headers: { 'Location': 'page/micropub' }, status: 302)
+        stub_request(:get, url).to_return(headers: { Location: 'page/micropub' }, status: 302)
 
-        stub_request(:get, "#{url}/micropub").to_return(headers: http_response_headers.merge('Link': "<#{endpoint}>; rel=micropub"))
+        stub_request(:get, "#{url}/micropub").to_return(headers: http_response_headers.merge(Link: "<#{endpoint}>; rel=micropub"))
       end
 
       it 'returns a String' do
@@ -269,7 +269,7 @@
     let(:url) { 'https://example.com/multiple_endpoints' }
 
     before do
-      stub_request(:get, url).to_return(headers: http_response_headers.merge('Link': %(<#{endpoint}>; rel="micropub")), body: read_fixture(url))
+      stub_request(:get, url).to_return(headers: http_response_headers.merge(Link: %(<#{endpoint}>; rel="micropub")), body: read_fixture(url))
     end
 
     it 'returns a String' do

spec/lib/indieweb/endpoints/parsers/microsub_parser_spec.rb

@@ -23,7 +23,7 @@
     # Similar to https://webmention.rocks/test/1
     context 'when the HTTP Link header references a relative URL and the `rel` parameter is unquoted' do
       before do
-        stub_request(:get, url).to_return(headers: { 'Link': '</microsub>; rel=microsub' })
+        stub_request(:get, url).to_return(headers: { Link: '</microsub>; rel=microsub' })
       end
 
       it 'returns a String' do
@@ -34,7 +34,7 @@
     # Similar to https://webmention.rocks/test/2
     context 'when the HTTP Link header references an absolute URL and the `rel` parameter is unquoted' do
       before do
-        stub_request(:get, url).to_return(headers: { 'Link': %(<#{endpoint}>; rel=microsub) })
+        stub_request(:get, url).to_return(headers: { Link: %(<#{endpoint}>; rel=microsub) })
       end
 
       it 'returns a String' do
@@ -56,7 +56,7 @@
     # Similar to https://webmention.rocks/test/8
     context 'when the `rel` parameter is quoted' do
       before do
-        stub_request(:get, url).to_return(headers: { 'Link': %(<#{endpoint}>; rel="microsub") })
+        stub_request(:get, url).to_return(headers: { Link: %(<#{endpoint}>; rel="microsub") })
       end
 
       it 'returns a String' do
@@ -67,7 +67,7 @@
     # Similar to https://webmention.rocks/test/10
     context 'when the `rel` parameter contains multiple space-separated values' do
       before do
-        stub_request(:get, url).to_return(headers: { 'Link': %(<#{endpoint}>; rel="microsub somethingelse") })
+        stub_request(:get, url).to_return(headers: { Link: %(<#{endpoint}>; rel="microsub somethingelse") })
       end
 
       it 'returns a String' do
@@ -78,7 +78,7 @@
     # Similar to https://webmention.rocks/test/18
     context 'when the response includes multiple HTTP Link headers' do
       before do
-        stub_request(:get, url).to_return(headers: { 'Link': [%(<#{endpoint}#error>; rel="microsub"), %(</microsub/error>; rel="microsub_error"), %(<#{endpoint}>; rel="microsub"), '</microsub/error>; rel="other"'] })
+        stub_request(:get, url).to_return(headers: { Link: [%(<#{endpoint}#error>; rel="microsub"), %(</microsub/error>; rel="microsub_error"), %(<#{endpoint}>; rel="microsub"), '</microsub/error>; rel="other"'] })
       end
 
       it 'returns a String' do
@@ -89,7 +89,7 @@
     # Similar to https://webmention.rocks/test/19
     context 'when the HTTP Link header contains multiple comma-separated values' do
       before do
-        stub_request(:get, url).to_return(headers: { 'Link': %(</microsub/error>; rel="other", <#{endpoint}>; rel="microsub") })
+        stub_request(:get, url).to_return(headers: { Link: %(</microsub/error>; rel="other", <#{endpoint}>; rel="microsub") })
       end
 
       it 'returns a String' do
@@ -104,9 +104,9 @@
       let(:endpoint) { 'https://example.com/page/microsub/endpoint' }
 
       before do
-        stub_request(:get, url).to_return(headers: { 'Location': 'page/microsub' }, status: 302)
+        stub_request(:get, url).to_return(headers: { Location: 'page/microsub' }, status: 302)
 
-        stub_request(:get, "#{url}/microsub").to_return(headers: http_response_headers.merge('Link': "<#{endpoint}>; rel=microsub"))
+        stub_request(:get, "#{url}/microsub").to_return(headers: http_response_headers.merge(Link: "<#{endpoint}>; rel=microsub"))
       end
 
       it 'returns a String' do
@@ -269,7 +269,7 @@
     let(:url) { 'https://example.com/multiple_endpoints' }
 
     before do
-      stub_request(:get, url).to_return(headers: http_response_headers.merge('Link': %(<#{endpoint}>; rel="microsub")), body: read_fixture(url))
+      stub_request(:get, url).to_return(headers: http_response_headers.merge(Link: %(<#{endpoint}>; rel="microsub")), body: read_fixture(url))
     end
 
     it 'returns a String' do

spec/lib/indieweb/endpoints/parsers/redirect_uri_parser_spec.rb

@@ -24,7 +24,7 @@
   context 'when given a URL advertising callback URLs in an HTTP Link header' do
     context 'when the HTTP Link header references a relative URL and the `rel` parameter is unquoted' do
       before do
-        stub_request(:get, url).to_return(headers: { 'Link': '</redirect>; rel=redirect_uri' })
+        stub_request(:get, url).to_return(headers: { Link: '</redirect>; rel=redirect_uri' })
       end
 
       it 'returns an Array' do
@@ -34,7 +34,7 @@
 
     context 'when the HTTP Link header references an absolute URL and the `rel` parameter is unquoted' do
       before do
-        stub_request(:get, url).to_return(headers: { 'Link': %(<#{endpoint}>; rel=redirect_uri) })
+        stub_request(:get, url).to_return(headers: { Link: %(<#{endpoint}>; rel=redirect_uri) })
       end
 
       it 'returns an Array' do
@@ -54,7 +54,7 @@
 
     context 'when the `rel` parameter is quoted' do
       before do
-        stub_request(:get, url).to_return(headers: { 'Link': %(<#{endpoint}>; rel="redirect_uri") })
+        stub_request(:get, url).to_return(headers: { Link: %(<#{endpoint}>; rel="redirect_uri") })
       end
 
       it 'returns an Array' do
@@ -64,7 +64,7 @@
 
     context 'when the `rel` parameter contains multiple space-separated values' do
       before do
-        stub_request(:get, url).to_return(headers: { 'Link': %(<#{endpoint}>; rel="redirect_uri somethingelse") })
+        stub_request(:get, url).to_return(headers: { Link: %(<#{endpoint}>; rel="redirect_uri somethingelse") })
       end
 
       it 'returns an Array' do
@@ -76,7 +76,7 @@
       let(:endpoints) { ['https://example.com/callback', 'https://example.com/redirect'] }
 
       before do
-        stub_request(:get, url).to_return(headers: { 'Link': [%(<#{endpoint}#error>; rel="redirect_uri"), %(</redirect_uri/error>; rel="redirect_uri_error"), %(<#{endpoint}>; rel="redirect_uri"), '</callback>; rel="redirect_uri"'] })
+        stub_request(:get, url).to_return(headers: { Link: [%(<#{endpoint}#error>; rel="redirect_uri"), %(</redirect_uri/error>; rel="redirect_uri_error"), %(<#{endpoint}>; rel="redirect_uri"), '</callback>; rel="redirect_uri"'] })
       end
 
       it 'returns an Array' do
@@ -86,7 +86,7 @@
 
     context 'when the HTTP Link header contains multiple comma-separated values' do
       before do
-        stub_request(:get, url).to_return(headers: { 'Link': %(</redirect_uri/error>; rel="other", <#{endpoint}>; rel="redirect_uri") })
+        stub_request(:get, url).to_return(headers: { Link: %(</redirect_uri/error>; rel="other", <#{endpoint}>; rel="redirect_uri") })
       end
 
       it 'returns an Array' do
@@ -100,9 +100,9 @@
       let(:endpoint) { 'https://example.com/page/redirect_uri/endpoint' }
 
       before do
-        stub_request(:get, url).to_return(headers: { 'Location': 'page/redirect_uri' }, status: 302)
+        stub_request(:get, url).to_return(headers: { Location: 'page/redirect_uri' }, status: 302)
 
-        stub_request(:get, "#{url}/redirect_uri").to_return(headers: http_response_headers.merge('Link': "<#{endpoint}>; rel=redirect_uri"))
+        stub_request(:get, "#{url}/redirect_uri").to_return(headers: http_response_headers.merge(Link: "<#{endpoint}>; rel=redirect_uri"))
       end
 
       it 'returns an Array' do
@@ -257,7 +257,7 @@
     let(:endpoints) { ['https://example.com/callback', 'https://example.com/redirect'] }
 
     before do
-      stub_request(:get, url).to_return(headers: http_response_headers.merge('Link': %(</redirect>; rel="redirect_uri")), body: read_fixture(url))
+      stub_request(:get, url).to_return(headers: http_response_headers.merge(Link: %(</redirect>; rel="redirect_uri")), body: read_fixture(url))
     end
 
     it 'returns an Array' do

spec/lib/indieweb/endpoints/parsers/token_endpoint_parser_spec.rb

@@ -23,7 +23,7 @@
     # Similar to https://webmention.rocks/test/1
     context 'when the HTTP Link header references a relative URL and the `rel` parameter is unquoted' do
       before do
-        stub_request(:get, url).to_return(headers: { 'Link': '</token_endpoint>; rel=token_endpoint' })
+        stub_request(:get, url).to_return(headers: { Link: '</token_endpoint>; rel=token_endpoint' })
       end
 
       it 'returns a String' do
@@ -34,7 +34,7 @@
     # Similar to https://webmention.rocks/test/2
     context 'when the HTTP Link header references an absolute URL and the `rel` parameter is unquoted' do
       before do
-        stub_request(:get, url).to_return(headers: { 'Link': %(<#{endpoint}>; rel=token_endpoint) })
+        stub_request(:get, url).to_return(headers: { Link: %(<#{endpoint}>; rel=token_endpoint) })
       end
 
       it 'returns a String' do
@@ -56,7 +56,7 @@
     # Similar to https://webmention.rocks/test/8
     context 'when the `rel` parameter is quoted' do
       before do
-        stub_request(:get, url).to_return(headers: { 'Link': %(<#{endpoint}>; rel="token_endpoint") })
+        stub_request(:get, url).to_return(headers: { Link: %(<#{endpoint}>; rel="token_endpoint") })
       end
 
       it 'returns a String' do
@@ -67,7 +67,7 @@
     # Similar to https://webmention.rocks/test/10
     context 'when the `rel` parameter contains multiple space-separated values' do
       before do
-        stub_request(:get, url).to_return(headers: { 'Link': %(<#{endpoint}>; rel="token_endpoint somethingelse") })
+        stub_request(:get, url).to_return(headers: { Link: %(<#{endpoint}>; rel="token_endpoint somethingelse") })
       end
 
       it 'returns a String' do
@@ -78,7 +78,7 @@
     # Similar to https://webmention.rocks/test/18
     context 'when the response includes multiple HTTP Link headers' do
       before do
-        stub_request(:get, url).to_return(headers: { 'Link': [%(<#{endpoint}#error>; rel="token_endpoint"), %(</token_endpoint/error>; rel="token_endpoint_error"), %(<#{endpoint}>; rel="token_endpoint"), '</token_endpoint/error>; rel="other"'] })
+        stub_request(:get, url).to_return(headers: { Link: [%(<#{endpoint}#error>; rel="token_endpoint"), %(</token_endpoint/error>; rel="token_endpoint_error"), %(<#{endpoint}>; rel="token_endpoint"), '</token_endpoint/error>; rel="other"'] })
       end
 
       it 'returns a String' do
@@ -89,7 +89,7 @@
     # Similar to https://webmention.rocks/test/19
     context 'when the HTTP Link header contains multiple comma-separated values' do
       before do
-        stub_request(:get, url).to_return(headers: { 'Link': %(</token_endpoint/error>; rel="other", <#{endpoint}>; rel="token_endpoint") })
+        stub_request(:get, url).to_return(headers: { Link: %(</token_endpoint/error>; rel="other", <#{endpoint}>; rel="token_endpoint") })
       end
 
       it 'returns a String' do
@@ -104,9 +104,9 @@
       let(:endpoint) { 'https://example.com/page/token_endpoint/endpoint' }
 
       before do
-        stub_request(:get, url).to_return(headers: { 'Location': 'page/token_endpoint' }, status: 302)
+        stub_request(:get, url).to_return(headers: { Location: 'page/token_endpoint' }, status: 302)
 
-        stub_request(:get, "#{url}/token_endpoint").to_return(headers: http_response_headers.merge('Link': "<#{endpoint}>; rel=token_endpoint"))
+        stub_request(:get, "#{url}/token_endpoint").to_return(headers: http_response_headers.merge(Link: "<#{endpoint}>; rel=token_endpoint"))
       end
 
       it 'returns a String' do
@@ -269,7 +269,7 @@
     let(:url) { 'https://example.com/multiple_endpoints' }
 
     before do
-      stub_request(:get, url).to_return(headers: http_response_headers.merge('Link': %(<#{endpoint}>; rel="token_endpoint")), body: read_fixture(url))
+      stub_request(:get, url).to_return(headers: http_response_headers.merge(Link: %(<#{endpoint}>; rel="token_endpoint")), body: read_fixture(url))
     end
 
     it 'returns a String' do