From 4569e65e28a609cbc56c46f33391212a9dc365be Mon Sep 17 00:00:00 2001 From: GriffTanen Date: Sun, 30 Aug 2026 17:46:33 +0300 Subject: [PATCH] Fix `silence_exceptions` tuple and comparison against missing update date Two unrelated latent bugs: * a stray trailing comma made `HttpClient.silence_exceptions` a tuple, always truthy, so `raise_on_error_response = True` never actually surfaced errors; * `get_torrent()` compared `last_updated` against `page_data.date_updated` without checking the latter for `None`, raising `TypeError` for trackers that do not extract a date or fail to parse one. Co-Authored-By: Claude Opus 5 --- src/torrt/base_tracker.py | 4 +++- src/torrt/utils.py | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/torrt/base_tracker.py b/src/torrt/base_tracker.py index 6e82eef..54c6385 100644 --- a/src/torrt/base_tracker.py +++ b/src/torrt/base_tracker.py @@ -382,7 +382,9 @@ def get_torrent(self, url: str, *, last_updated: datetime | None = None) -> Torr self.log_debug(f'Torrent download link found: {download_link}') - if last_updated and last_updated >= page_data.date_updated: + date_updated = page_data.date_updated + + if last_updated and date_updated and last_updated >= date_updated: self.log_debug('Skipped as up to date') return None else: diff --git a/src/torrt/utils.py b/src/torrt/utils.py index 33a893a..b6bf2e5 100644 --- a/src/torrt/utils.py +++ b/src/torrt/utils.py @@ -55,7 +55,7 @@ def __init__( }) self.session = session - self.silence_exceptions = silence_exceptions, + self.silence_exceptions = silence_exceptions self.dump_fname_tpl = dump_fname_tpl self.json = json self.last_error: str = ''