Skip to content

Commit 96f60c7

Browse files
committed
Enable ruff ERA rule and remove commented-out code
Remove commented-out gateway enum entry and disabled test case. Add noqa for false positive on a format description comment.
1 parent 825b6b7 commit 96f60c7

File tree

4 files changed

+3
-7
lines changed

4 files changed

+3
-7
lines changed

pyoverkiz/enums/gateway.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,6 @@ class GatewaySubType(UnknownEnumMixin, IntEnum):
9494
TAHOMA_PRO = 14
9595
TAHOMA_SECURITY_SHORT_CHANNEL = 15
9696
TAHOMA_SECURITY_PRO = 16
97-
# TAHOMA_BOX_C_IO = 12 # Note: This is likely 17, but tahomalink.com lists it as 12
9897

9998
@property
10099
def beautify_name(self) -> str:

pyproject.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,8 @@ select = [
7373
"C4",
7474
# pep8-naming
7575
"N",
76+
# eradicate
77+
"ERA",
7678
]
7779
ignore = ["E501"] # Line too long
7880

tests/test_client.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -469,11 +469,6 @@ async def test_get_diagnostic_data_without_masking(self, client: OverkizClient):
469469
exceptions.ResourceAccessDeniedError,
470470
400,
471471
),
472-
# (
473-
# "local/204-no-corresponding-execId.json",
474-
# exceptions.OverkizError,
475-
# 204,
476-
# ),
477472
(
478473
"local/400-bad-parameters.json",
479474
exceptions.OverkizError,

utils/generate_enums.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
from pyoverkiz.models import UIProfileDefinition, ValuePrototype
2222

2323
# Hardcoded protocols that may not be available on all servers
24-
# Format: (name, prefix, id, label)
24+
# Format: (name, prefix, id, label) # noqa: ERA001
2525
ADDITIONAL_PROTOCOLS: list[tuple[str, str, int | None, str | None]] = [
2626
("HLRR_WIFI", "hlrrwifi", None, None),
2727
("MODBUSLINK", "modbuslink", 44, "ModbusLink"), # via Atlantic Cozytouch

0 commit comments

Comments
 (0)