Skip to content

Commit 8d6d16b

Browse files
committed
Refactor type casting in UnknownEnumMixin and generate_enums for cleaner code
1 parent db8c038 commit 8d6d16b

2 files changed

Lines changed: 5 additions & 7 deletions

File tree

pyoverkiz/enums/base.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
from __future__ import annotations
44

55
import logging
6-
from typing import Self, cast
6+
from typing import Self
77

88

99
class UnknownEnumMixin:
@@ -35,5 +35,4 @@ def _missing_(cls, value: object) -> Self: # type: ignore[override]
3535
"""
3636
message = cls.__missing_message__
3737
logging.getLogger(cls.__module__).warning(message, value, cls)
38-
# Type checker cannot infer UNKNOWN exists on Self, but all subclasses define it
39-
return cast(Self, cls.UNKNOWN) # type: ignore[attr-defined]
38+
return cls.UNKNOWN # type: ignore[attr-defined] # ty: ignore[unresolved-attribute]

utils/generate_enums.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
import re
1313
import subprocess
1414
from pathlib import Path
15-
from typing import cast
1615

1716
from pyoverkiz.auth.credentials import UsernamePasswordCredentials
1817
from pyoverkiz.client import OverkizClient
@@ -129,8 +128,8 @@ async def generate_ui_enums(server: Server) -> None:
129128
) as client:
130129
await client.login()
131130

132-
ui_classes = cast(list[str], await client.get_reference_ui_classes())
133-
ui_widgets = cast(list[str], await client.get_reference_ui_widgets())
131+
ui_classes = await client.get_reference_ui_classes()
132+
ui_widgets = await client.get_reference_ui_widgets()
134133

135134
# Convert camelCase to SCREAMING_SNAKE_CASE for enum names
136135
def to_enum_name(value: str) -> str:
@@ -210,7 +209,7 @@ def to_enum_name(value: str) -> str:
210209
lines.append("") # End with newline
211210

212211
# Fetch and add UI classifiers
213-
ui_classifiers = cast(list[str], await client.get_reference_ui_classifiers())
212+
ui_classifiers = await client.get_reference_ui_classifiers()
214213

215214
lines.append("")
216215
lines.append("@unique")

0 commit comments

Comments
 (0)