Fix PR review feedback: restore test assertions and simplify ActionQueue settings storage

- Add missing pytest.raises assertions for Nexity auth tests that were
  silently passing without verifying exception behavior
- Store ActionQueueSettings directly instead of unpacking into separate fields

Author: iMicknl

pyoverkiz/action_queue.py

@@ -96,9 +96,7 @@ def __init__(
         :param settings: Queue configuration (uses defaults if None)
         """
         self._executor = executor
-        settings = settings or ActionQueueSettings()
-        self._delay = settings.delay
-        self._max_actions = settings.max_actions
+        self._settings = settings or ActionQueueSettings()
 
         self._pending_actions: list[Action] = []
         self._pending_mode: ExecutionMode | None = None
@@ -187,7 +185,7 @@ async def add(
             self._pending_waiters.append(waiter)
 
             # If we hit max actions, flush immediately
-            if len(self._pending_actions) >= self._max_actions:
+            if len(self._pending_actions) >= self._settings.max_actions:
                 # Prepare the current batch for flushing (which includes the actions
                 # we just added). If we already flushed due to mode change, this is
                 # a second batch.
@@ -207,7 +205,7 @@ async def _delayed_flush(self) -> None:
         """Wait for the delay period, then flush the queue."""
         waiters: list[QueuedExecution] = []
         try:
-            await asyncio.sleep(self._delay)
+            await asyncio.sleep(self._settings.delay)
             async with self._lock:
                 if not self._pending_actions:
                     return

tests/test_auth.py

@@ -37,7 +37,7 @@
     _decode_jwt_payload,
 )
 from pyoverkiz.enums import APIType, Server
-from pyoverkiz.exceptions import InvalidTokenError
+from pyoverkiz.exceptions import InvalidTokenError, NexityBadCredentialsError
 from pyoverkiz.models import ServerConfig
 
 
@@ -523,7 +523,8 @@ async def test_login_maps_invalid_credentials_client_error(self):
             patch("warrant_lite.WarrantLite", return_value=warrant_instance),
         ):
             strategy = NexityAuthStrategy(credentials, session, server_config, True)
-            await strategy.login()
+            with pytest.raises(NexityBadCredentialsError):
+                await strategy.login()
 
     @pytest.mark.asyncio
     async def test_login_propagates_non_auth_client_error(self):
@@ -550,7 +551,8 @@ async def test_login_propagates_non_auth_client_error(self):
             patch("warrant_lite.WarrantLite", return_value=warrant_instance),
         ):
             strategy = NexityAuthStrategy(credentials, session, server_config, True)
-            await strategy.login()
+            with pytest.raises(ClientError, match="InternalErrorException"):
+                await strategy.login()
 
 
 class TestRexelAuthStrategy: