refactor(tests): use explicit assertions following Python idioms

- Use `is None` / `is not None` for explicit None checks (PEP 8)
- Use `pytest.raises(TypeError, lambda: expr)` for exception tests
- Keep `assert collection` for empty/non-empty checks (Pythonic)

Author: tetienne

tests/test_client.py

@@ -194,9 +194,9 @@ async def test_get_setup(
             assert len(setup.gateways) == gateway_count
 
             for device in setup.devices:
-                assert device.gateway_id
-                assert device.device_address
-                assert device.protocol
+                assert device.gateway_id is not None
+                assert device.device_address is not None
+                assert device.protocol is not None
 
     @pytest.mark.parametrize(
         "fixture_name",
@@ -238,7 +238,7 @@ async def test_get_diagnostic_data(self, client: OverkizClient, fixture_name: st
 
         with patch.object(aiohttp.ClientSession, "get", return_value=resp):
             diagnostics = await client.get_diagnostic_data()
-            assert diagnostics
+            assert diagnostics is not None
 
     @pytest.mark.parametrize(
         "fixture_name, exception, status_code",
@@ -446,16 +446,16 @@ async def test_get_scenarios(
             assert len(scenarios) == scenario_count
 
             for scenario in scenarios:
-                assert scenario.oid
+                assert scenario.oid is not None
                 assert scenario.label is not None
                 assert scenario.actions
 
                 for action in scenario.actions:
-                    assert action.device_url
+                    assert action.device_url is not None
                     assert action.commands
 
                     for command in action.commands:
-                        assert command.name
+                        assert command.name is not None
 
 
 class MockResponse:

tests/test_models.py

@@ -201,7 +201,7 @@ def test_none_states(self):
         hump_device = humps.decamelize(RAW_DEVICES)
         del hump_device["states"]
         device = Device(**hump_device)
-        assert not device.states.get(STATE)
+        assert device.states.get(STATE) is None
 
 
 class TestStates:
@@ -211,19 +211,19 @@ def test_empty_states(self):
         """An empty list yields an empty States object with no state found."""
         states = States([])
         assert not states
-        assert not states.get(STATE)
+        assert states.get(STATE) is None
 
     def test_none_states(self):
         """A None value for states should behave as empty."""
         states = States(None)
         assert not states
-        assert not states.get(STATE)
+        assert states.get(STATE) is None
 
     def test_getter(self):
         """Retrieve a known state and validate its properties."""
         states = States(RAW_STATES)
         state = states.get(STATE)
-        assert state
+        assert state is not None
         assert state.name == STATE
         assert state.type == DataType.STRING
         assert state.value == "alarm name"
@@ -232,7 +232,7 @@ def test_getter_missing(self):
         """Requesting a missing state returns falsy (None)."""
         states = States(RAW_STATES)
         state = states.get("FooState")
-        assert not state
+        assert state is None
 
 
 class TestState:
@@ -246,8 +246,7 @@ def test_int_value(self):
     def test_bad_int_value(self):
         """Accessor raises TypeError if the state type mismatches expected int."""
         state = State(name="state", type=DataType.BOOLEAN, value=False)
-        with pytest.raises(TypeError):
-            assert state.value_as_int
+        pytest.raises(TypeError, lambda: state.value_as_int)
 
     def test_float_value(self):
         """Float typed state returns proper float accessor."""
@@ -257,8 +256,7 @@ def test_float_value(self):
     def test_bad_float_value(self):
         """Accessor raises TypeError if the state type mismatches expected float."""
         state = State(name="state", type=DataType.BOOLEAN, value=False)
-        with pytest.raises(TypeError):
-            assert state.value_as_float
+        pytest.raises(TypeError, lambda: state.value_as_float)
 
     def test_bool_value(self):
         """Boolean typed state returns proper boolean accessor."""
@@ -268,8 +266,7 @@ def test_bool_value(self):
     def test_bad_bool_value(self):
         """Accessor raises TypeError if the state type mismatches expected bool."""
         state = State(name="state", type=DataType.INTEGER, value=1)
-        with pytest.raises(TypeError):
-            assert state.value_as_bool
+        pytest.raises(TypeError, lambda: state.value_as_bool)
 
     def test_str_value(self):
         """String typed state returns proper string accessor."""
@@ -279,8 +276,7 @@ def test_str_value(self):
     def test_bad_str_value(self):
         """Accessor raises TypeError if the state type mismatches expected string."""
         state = State(name="state", type=DataType.BOOLEAN, value=False)
-        with pytest.raises(TypeError):
-            assert state.value_as_str
+        pytest.raises(TypeError, lambda: state.value_as_str)
 
     def test_dict_value(self):
         """JSON object typed state returns proper dict accessor."""
@@ -290,8 +286,7 @@ def test_dict_value(self):
     def test_bad_dict_value(self):
         """Accessor raises TypeError if the state type mismatches expected dict."""
         state = State(name="state", type=DataType.BOOLEAN, value=False)
-        with pytest.raises(TypeError):
-            assert state.value_as_dict
+        pytest.raises(TypeError, lambda: state.value_as_dict)
 
     def test_list_value(self):
         """JSON array typed state returns proper list accessor."""
@@ -301,5 +296,4 @@ def test_list_value(self):
     def test_bad_list_value(self):
         """Accessor raises TypeError if the state type mismatches expected list."""
         state = State(name="state", type=DataType.BOOLEAN, value=False)
-        with pytest.raises(TypeError):
-            assert state.value_as_list
+        pytest.raises(TypeError, lambda: state.value_as_list)

tests/test_utils.py

@@ -18,7 +18,7 @@ def test_generate_local_server(self):
         """Create a local server descriptor using the host and default values."""
         local_server = generate_local_server(host=LOCAL_HOST)
 
-        assert local_server
+        assert local_server is not None
         assert (
             local_server.endpoint
             == "https://gateway-1234-5678-1243.local:8443/enduser-mobile-web/1/enduserAPI/"
@@ -36,7 +36,7 @@ def test_generate_local_server_by_ip(self):
             configuration_url="https://somfy.com",
         )
 
-        assert local_server
+        assert local_server is not None
         assert (
             local_server.endpoint
             == "https://192.168.1.105:8443/enduser-mobile-web/1/enduserAPI/"