Repository navigation
Vouch Request: Improve Screencopy in xdph for scaled displays #150
Repos I am interested in contributing tohttps://github.com/hyprwm/xdg-desktop-portal-hyprland What I want to contribute right nowI have implemented a fix (with the help of Claude) for xdph which allows stream position and size to be reported correctly from the streamcopy protocol: this fixes a bug I found while setting up Waytator (https://github.com/faetalize/waytator/), which is a screenshotting and screen recording tool. Waytator checks that the monitor that was given to it matches the monitor it requested. Waytator assumes the resolution to match the compositor coordinate space (as per the xdg specification here https://flatpak.github.io/xdg-desktop-portal/docs/doc-org.freedesktop.impl.portal.ScreenCast.html#org-freedesktop-impl-portal-screencast-start), whereas xdph provides the resolution of the pixel buffer size. hyprwm/xdg-desktop-portal-hyprland#459 Why the above bug / feature specifically?I came up against this issue myself, found a workaround within waytator but it seemed like the wrong place to contribute a fix. I acknowledge that:
|
Replies: 2 comments
|
hi, waytator dev here, i haven't had a look at the patch yet but it would be nice to get this sorted |
|
welcome aboard! |
welcome aboard!