Repository navigation
Vouch request: drm: skip modifiers already in the plane format list #146
Replies: 1 comment
|
welcome aboard! |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Repos I am interested in contributing to
aquamarine
What I want to contribute right now
Since 7.3 amdgpu exposes IN_FORMATS on the cursor plane for older cards too, so LINEAR ends up in the list twice. The gbm fallback only handles the list being exactly LINEAR, so with the dup the cursor bo gets allocated with DRM_FORMAT_MOD_INVALID, which aquamarine then refuses to commit to the cursor plane, so the cursor is just gone.
This just checks if the modifier is already there before adding it.
PR: hyprwm/aquamarine#497
Issue: hyprwm/aquamarine#476
Why the above bug / feature specifically?
Hit this myself on an RX 580, cursor disappeared after the 7.3 kernel update. Same thing is reported in hyprwm/aquamarine#476 on an RX 570. Tracked it down to a duplicated LINEAR modifier on the cursor plane and tested the fix on my card.
I acknowledge that:
I have read the AI Usage Policy and agree to follow it.
I have read the Code of Conduct and agree to follow it.
I wrote this request with my own hands, my own keyboard, and in my own words.
All reactions