Repository navigation
Voucher Request (unclej4ck) #139
Replies: 1 comment
|
Yep I know you, welcome aboard! |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Repos I am interested in contributing to
Hyprlock, Aquamarine, Hyprpolkitagent, hyprtoolkit, hyprland
What I want to contribute right now
I want to fix how hyprtoolkit resolves icon themes. A theme's icons can be spread across several base directories, but only one of them holds the index.theme file. The loader only searched the base directory with the index.theme, so any icon sitting in another base directory was never found. Chromium is the clearest example: it drops installed PWA and app icons into ~/.local/share/icons/hicolor with no index.theme beside them, so those icons just render blank. My fix adds each theme directory under every base directory, so all of them get searched. The branch is https://github.com/UncleJ4ck/hyprtoolkit/tree/fix-icon-cross-base-dirs. I opened it as a PR first (#151), before I knew about the vouch requirement, so it got closed automatically. I'll reopen it once I'm vouched.
Why the above bug / feature specifically?
I hit this one myself. I install a few web apps as PWAs through Chromium, and their icons kept showing up empty in hyprtoolkit based UIs while the same icons were fine everywhere else. Once I dug in, I saw the loader was only ever checking one base directory, so whatever Chromium wrote into a different one was just invisible to it. It's a small bug, but it's the kind you keep noticing once you've seen it. The fix is clean, so I'd rather land it than keep working around it on my own machine
I acknowledge that:
I have read the AI Usage Policy and agree to follow it.
I have read the Code of Conduct and agree to follow it.
I wrote this request with my own hands, my own keyboard, and in my own words.
All reactions