fix(deps): replace serde_yaml with safe-Rust serde-saphyr

serde_yaml 0.9 is deprecated and depends on unsafe-libyaml, an archived
c2rust translation of libyaml flagged unmaintained by RUSTSEC-2024-0449.
Swap in serde-saphyr 2.0 (#![forbid(unsafe_code)]) behind a small
crate::yaml module:

- hand-written configs (attack profiles, ambush timelines, amuck specs)
  use serde-saphyr's default resource budget;
- machine-written reports (diff loader, a2ml bundles, attack results)
  get a node/event budget scaled to input length. The default 250k-node
  cap rejected YAML reports from scans over ~15k files; an alias-free
  document cannot have more nodes than bytes, so alias expansion stays
  bounded.

Raise rust-version from 1.85.0 to 1.89: every serde-saphyr release that
compiles on 1.85 is pre-1.0 and unmaintained (1.1.0 uses let-chains and
is_multiple_of despite declaring no MSRV), noyalib needs 1.86+, and the
committed lockfile already required 1.88 (encoding_rs, sha2, proptest).
Default, http/signing/sarif and test builds verified on 1.89.0 --locked.

YAML output is value-equivalent but not byte-identical ('…' -> "…",
multi-line strings as | blocks); nothing compares the bytes, and
reports written by serde_yaml still load (new fixture test). KYAML
input parses (new test). cargo audit: RUSTSEC-2024-0449 gone, no new
advisories.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PFaqv6iBXrt3W5Akd1Fq5k

Author: claude

.github/CONTRIBUTING.md

@@ -67,7 +67,7 @@ enhancement suggestion:
 
 ### Prerequisites
 
-- Rust 1.85.0 or later (MSRV)
+- Rust 1.89 or later (MSRV)
 
 - Cargo
 

.machine_readable/svc/k9/panic-attacker-metadata.k9.ncl

@@ -54,7 +54,7 @@ K9!
     # Build configuration
     build = {
       edition = "2021",
-      msrv = "1.85.0",
+      msrv = "1.89",
     },
 
     # Language policy

0-AI-MANIFEST.a2ml

@@ -82,7 +82,7 @@
     (build-system "cargo")
     (package-manager "cargo")
     (language "rust")
-    (msrv "1.85.0")
+    (msrv "1.89")
     (edition "2021"))
 
   (lifecycle

CHANGELOG.adoc

@@ -2,6 +2,25 @@
 
 === [Unreleased]
 
+==== Fixed — YAML parser replaced with safe Rust (RUSTSEC-2024-0449)
+
+* *`+serde_yaml+` → `+serde-saphyr+` 2.0.* `+serde_yaml+` 0.9 is
+deprecated and pulled in `+unsafe-libyaml+`, an archived c2rust
+translation of libyaml flagged unmaintained by RUSTSEC-2024-0449.
+`+serde-saphyr+` is `+#![forbid(unsafe_code)]+`. All YAML now goes
+through `+src/yaml.rs+`: hand-written configs (attack profiles,
+timelines, amuck specs) keep the parser's default resource budget;
+machine-written reports get a node/event budget scaled to input
+length, so large-scan reports still load while alias expansion stays
+bounded.
+* *MSRV raised from 1.85.0 to 1.89.* No maintained safe-Rust serde
+YAML crate builds on 1.85 (serde-saphyr needs 1.89, noyalib 1.86+),
+and the committed lockfile already required 1.88.
+* *YAML output is equivalent but not byte-identical.* Quoting switches
+from `+'…'+` to `+"…"+` and multi-line strings use `+|+` blocks.
+Reports written by earlier versions still load. A bare `+~+`/`+null+`
+in a string field is now rejected (YAML 1.2 null); quote it.
+
 ==== Fixed — assail detector precision (false-positive reduction, 2026-06-24)
 
 Three `+assail+` analyzer fixes, all conservative (no new false

Cargo.lock

@@ -3,7 +3,7 @@
 name = "panic-attack"
 version = "2.5.5"
 edition = "2021"
-rust-version = "1.85.0"
+rust-version = "1.89"
 authors = ["Jonathan D.A. Jewell <j.d.a.jewell@open.ac.uk>"]
 license-file = "LICENSE"
 description = "Universal static analysis, stress testing, and logic-based bug signature detection for 49 languages"
@@ -18,7 +18,8 @@ anyhow = "1.0"
 log = "0.4"
 serde = { version = "1.0", features = ["derive"] }
 serde_json = "1.0"
-serde_yaml = "0.9"
+# Pure safe-Rust YAML (replaces serde_yaml + unsafe-libyaml, RUSTSEC-2024-0449).
+serde-saphyr = "2.0"
 regex = "1.10"
 chrono = "0.4"
 filetime = "0.2"
@@ -41,7 +42,7 @@ signing = ["ed25519-dalek"]
 http = ["ureq"]
 sarif = []
 # Native GUI viewer (eframe/egui). Opt-in because eframe raises MSRV above the
-# 1.85.0 baseline; default builds remain pure-CLI and MSRV-clean.
+# 1.89 baseline; default builds remain pure-CLI and MSRV-clean.
 gui = ["eframe"]
 
 [dev-dependencies]

Cargo.toml

@@ -401,9 +401,8 @@ fn load_payload_for_kind(kind: ReportBundleKind, input: &Path) -> Result<ReportB
 fn load_json_or_yaml<T: DeserializeOwned>(path: &Path) -> Result<T> {
     let raw = fs::read_to_string(path).with_context(|| format!("reading {}", path.display()))?;
     match path.extension().and_then(|e| e.to_str()) {
-        Some("yaml") | Some("yml") => {
-            serde_yaml::from_str::<T>(&raw).with_context(|| format!("parsing {}", path.display()))
-        }
+        Some("yaml") | Some("yml") => crate::yaml::from_report_str::<T>(&raw)
+            .with_context(|| format!("parsing {}", path.display())),
         _ => serde_json::from_str::<T>(&raw).with_context(|| format!("parsing {}", path.display())),
     }
 }
@@ -421,10 +420,10 @@ fn load_attack_results(path: &Path) -> Result<Vec<AttackResult>> {
     if let Ok(wrapper) = serde_json::from_str::<AttackWrapper>(&raw) {
         return Ok(wrapper.attack_results);
     }
-    if let Ok(results) = serde_yaml::from_str::<Vec<AttackResult>>(&raw) {
+    if let Ok(results) = crate::yaml::from_report_str::<Vec<AttackResult>>(&raw) {
         return Ok(results);
     }
-    if let Ok(wrapper) = serde_yaml::from_str::<AttackWrapper>(&raw) {
+    if let Ok(wrapper) = crate::yaml::from_report_str::<AttackWrapper>(&raw) {
         return Ok(wrapper.attack_results);
     }
     Err(anyhow!(

src/a2ml/mod.rs

@@ -72,7 +72,7 @@ pub fn load_timeline_with_default(
     let spec: TimelineSpec = if path.extension().and_then(|s| s.to_str()) == Some("yaml")
         || path.extension().and_then(|s| s.to_str()) == Some("yml")
     {
-        serde_yaml::from_str(&content)
+        crate::yaml::from_str(&content)
             .with_context(|| format!("parsing yaml timeline {}", path.display()))?
     } else {
         serde_json::from_str(&content)

src/ambush/timeline.rs

@@ -320,19 +320,19 @@ fn load_spec(path: &Path) -> Result<MutationSpecFile> {
             .with_context(|| format!("reading spec {}", path.display()))?;
         buf
     };
-    let spec =
-        match path.extension().and_then(|ext| ext.to_str()) {
-            Some("json") => serde_json::from_str(&content)
-                .with_context(|| format!("parsing {}", path.display()))?,
-            Some("yaml") | Some("yml") => serde_yaml::from_str(&content)
-                .with_context(|| format!("parsing {}", path.display()))?,
-            _ => {
-                return Err(anyhow!(
-                    "spec {} must be json/yaml/yml",
-                    path.to_string_lossy()
-                ));
-            }
-        };
+    let spec = match path.extension().and_then(|ext| ext.to_str()) {
+        Some("json") => {
+            serde_json::from_str(&content).with_context(|| format!("parsing {}", path.display()))?
+        }
+        Some("yaml") | Some("yml") => crate::yaml::from_str(&content)
+            .with_context(|| format!("parsing {}", path.display()))?,
+        _ => {
+            return Err(anyhow!(
+                "spec {} must be json/yaml/yml",
+                path.to_string_lossy()
+            ));
+        }
+    };
     Ok(spec)
 }
 

src/amuck/mod.rs

@@ -7,7 +7,6 @@ use crate::types::{AttackAxis, ProbeMode};
 use anyhow::{anyhow, Context, Result};
 use serde::Deserialize;
 use serde_json;
-use serde_yaml;
 use std::collections::HashMap;
 use std::fs::File;
 use std::io::Read;
@@ -43,7 +42,7 @@ impl AttackProfile {
         match path.extension().and_then(|ext| ext.to_str()) {
             Some("json") => serde_json::from_str(&content)
                 .with_context(|| format!("parsing json attack profile {}", path.display())),
-            Some("yaml") | Some("yml") => serde_yaml::from_str(&content)
+            Some("yaml") | Some("yml") => crate::yaml::from_str(&content)
                 .with_context(|| format!("parsing yaml attack profile {}", path.display())),
             _ => Err(anyhow!(
                 "unsupported attack profile extension for {}",