Skip to content

Commit 2afaa4c

Browse files
arena-ai-coding-agent[bot]hyperpolymatharena-agent
authored
Fail supervised scans on incomplete coverage (#573)
## Summary - Propagate supervised inventory resolver failures rather than hiding process-substitution errors. - Fail when no supervised repositories resolve, preventing false-green scans. - Return failure when any repository scan fails. ## Validation - - �[0;31m[ERROR]�[0m Failed to resolve supervised repository inventory exits 1. - Automation quarantine, directive census, session-detritus, and dispatch-path tests pass. - Retired-descriptile test could not run because Ruby is unavailable; repository-wide syntax scan reports a pre-existing syntax error in . Co-authored-by: hyperpolymath <6759885+hyperpolymath@users.noreply.github.com> Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
1 parent fa1ec2a commit 2afaa4c

1 file changed

Lines changed: 15 additions & 3 deletions

File tree

‎fleet-coordinator.sh‎

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -155,11 +155,18 @@ scan_supervised_repos() {
155155
fi
156156

157157
local -a repo_paths
158-
mapfile -t repo_paths < <("$list_script" "${args[@]}")
158+
local resolved_repos
159+
if ! resolved_repos=$("$list_script" "${args[@]}"); then
160+
log_error "Failed to resolve supervised repository inventory"
161+
return 1
162+
fi
163+
if [[ -n "$resolved_repos" ]]; then
164+
mapfile -t repo_paths <<< "$resolved_repos"
165+
fi
159166

160167
if [[ "${#repo_paths[@]}" -eq 0 ]]; then
161-
log_warn "No supervised repositories resolved"
162-
return 0
168+
log_error "No supervised repositories resolved; refusing a false-green scan"
169+
return 1
163170
fi
164171

165172
log_info "Scanning ${#repo_paths[@]} supervised repos"
@@ -176,6 +183,11 @@ scan_supervised_repos() {
176183

177184
log_info "Supervised scan complete: scanned=$scanned failed=$failed"
178185

186+
if [[ "$failed" -gt 0 ]]; then
187+
log_error "Supervised scan incomplete: $failed of ${#repo_paths[@]} repositories failed"
188+
return 1
189+
fi
190+
179191
if [[ "$process_after" == true ]]; then
180192
process_findings
181193
fi

0 commit comments

Comments
 (0)