Skip to content

Commit 82d5935

Browse files
Add list parsing key-display helper usage guard
Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>
1 parent 82eb728 commit 82d5935

3 files changed

Lines changed: 17 additions & 0 deletions

File tree

‎CONTRIBUTING.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,7 @@ This runs lint, format checks, compile checks, tests, and package build.
165165
- `tests/test_job_start_payload_helper_usage.py` (shared scrape/crawl start-payload helper usage enforcement),
166166
- `tests/test_job_wait_helper_boundary.py` (centralization boundary enforcement for wait-for-job helper primitives),
167167
- `tests/test_job_wait_helper_usage.py` (shared wait-for-job defaults helper usage enforcement),
168+
- `tests/test_list_parsing_key_display_helper_usage.py` (list parsing safe key-display helper usage enforcement),
168169
- `tests/test_makefile_quality_targets.py` (Makefile quality-gate target enforcement),
169170
- `tests/test_manager_helper_import_boundary.py` (manager helper-import boundary enforcement for low-level parse modules),
170171
- `tests/test_manager_model_dump_usage.py` (manager serialization centralization),

‎tests/test_architecture_marker_usage.py‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,7 @@
125125
"tests/test_job_request_helper_usage.py",
126126
"tests/test_job_start_payload_helper_usage.py",
127127
"tests/test_job_query_params_helper_usage.py",
128+
"tests/test_list_parsing_key_display_helper_usage.py",
128129
"tests/test_job_wait_helper_boundary.py",
129130
"tests/test_job_wait_helper_usage.py",
130131
"tests/test_example_sync_async_parity.py",
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
from pathlib import Path
2+
3+
import pytest
4+
5+
pytestmark = pytest.mark.architecture
6+
7+
LIST_PARSING_MODULE = Path("hyperbrowser/client/managers/list_parsing_utils.py")
8+
9+
10+
def test_list_parsing_uses_safe_key_display_helper():
11+
module_text = LIST_PARSING_MODULE.read_text(encoding="utf-8")
12+
13+
assert "safe_key_display_for_error(" in module_text
14+
assert "key_display=key_display" in module_text
15+
assert "read_value_error_builder=lambda key_text" in module_text

0 commit comments

Comments
 (0)