Reject control characters in base URL normalization

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/config.py

@@ -40,6 +40,11 @@ def normalize_base_url(base_url: str) -> str:
             raise HyperbrowserError("base_url must not contain whitespace characters")
         if "\\" in normalized_base_url:
             raise HyperbrowserError("base_url must not contain backslashes")
+        if any(
+            ord(character) < 32 or ord(character) == 127
+            for character in normalized_base_url
+        ):
+            raise HyperbrowserError("base_url must not contain control characters")
 
         parsed_base_url = urlparse(normalized_base_url)
         if (

tests/test_config.py

@@ -222,6 +222,10 @@ def test_client_config_rejects_empty_or_invalid_base_url():
         HyperbrowserError, match="base_url must not contain backslashes"
     ):
         ClientConfig(api_key="test-key", base_url="https://example.local\\api")
+    with pytest.raises(
+        HyperbrowserError, match="base_url must not contain control characters"
+    ):
+        ClientConfig(api_key="test-key", base_url="https://example.local\x00api")
 
 
 def test_client_config_normalizes_headers_to_internal_copy():
@@ -341,3 +345,7 @@ def test_client_config_normalize_base_url_validates_and_normalizes():
         HyperbrowserError, match="base_url must not contain backslashes"
     ):
         ClientConfig.normalize_base_url("https://example.local\\api")
+    with pytest.raises(
+        HyperbrowserError, match="base_url must not contain control characters"
+    ):
+        ClientConfig.normalize_base_url("https://example.local\x00api")

tests/test_url_building.py

@@ -116,6 +116,12 @@ def test_client_build_url_rejects_runtime_invalid_base_url_changes():
         ):
             client._build_url("/session")
 
+        client.config.base_url = "https://example.local\x00api"
+        with pytest.raises(
+            HyperbrowserError, match="base_url must not contain control characters"
+        ):
+            client._build_url("/session")
+
         client.config.base_url = "   "
         with pytest.raises(HyperbrowserError, match="base_url must not be empty"):
             client._build_url("/session")